Re: [libiberty patch] PEX-unix forking

2018-08-20 Thread Nathan Sidwell
On 08/20/2018 05:36 PM, Ian Lance Taylor wrote: As a matter of style I don't personally like the pattern in which a condition has both tests and actions. It's too easy to miss the action. I would prefer to see this more like the original code: if (!bad_fn && in != STDIN_FILE_NO) {

Re: [libiberty patch] PEX-unix forking

2018-08-20 Thread Ian Lance Taylor via gcc-patches
On Mon, Aug 20, 2018 at 10:38 AM, Nathan Sidwell wrote: > > This is the first of a pair of patches I've had on the modules branch for a > while. They improve the error behaviour in the case of child failure when > vfork is the forking mechanism. > > This one commonizes the error paths in the pare

[libiberty patch] PEX-unix forking

2018-08-20 Thread Nathan Sidwell
This is the first of a pair of patches I've had on the modules branch for a while. They improve the error behaviour in the case of child failure when vfork is the forking mechanism. This one commonizes the error paths in the parent and child to a pair of single blocks that print or return the