Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-26 Thread Cary Coutant
> >>> This patch is OK, with or without the testsuite additions Jakub > >>> mentions. > >> > >> Thanks, I added the new tests, and tweaked the clone suffix parsing to > >> allow the leading "_". > >> > >> Committed as r179132. > > > > Should I backport this patch to gcc-4_6-branch? > > Since you of

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Ian Lance Taylor
Cary Coutant writes: >>> This patch is OK, with or without the testsuite additions Jakub >>> mentions. >> >> Thanks, I added the new tests, and tweaked the clone suffix parsing to >> allow the leading "_". >> >> Committed as r179132. > > Should I backport this patch to gcc-4_6-branch? Since you

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Cary Coutant
>> This patch is OK, with or without the testsuite additions Jakub >> mentions. > > Thanks, I added the new tests, and tweaked the clone suffix parsing to > allow the leading "_". > > Committed as r179132. Should I backport this patch to gcc-4_6-branch? -cary

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Cary Coutant
> This patch is OK, with or without the testsuite additions Jakub > mentions. Thanks, I added the new tests, and tweaked the clone suffix parsing to allow the leading "_". Committed as r179132. -cary

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Ian Lance Taylor
Jakub Jelinek writes: > On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote: >> > Ping? >> > >> > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html > > It looks good to me, but I'd prefer if Ian with his demangler author > and libiberty maintainer hats looked at it too. This patch

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Jakub Jelinek
On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote: > > Ping? > > > > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html It looks good to me, but I'd prefer if Ian with his demangler author and libiberty maintainer hats looked at it too. > > include/ChangeLog: > > > >        PR 408

Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-22 Thread Cary Coutant
> Ping? > > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html > > -cary > > > include/ChangeLog: > >        PR 40831 >        * demangle.h (enum demangle_component_type): Add >        DEMANGLE_COMPONENT_CLONE. > > libiberty/ChangeLog: > >        PR 40831 >        * cp-demangle.c (d_make_comp)

Re: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-08 Thread Cary Coutant
Ping? http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html -cary include/ChangeLog:        PR 40831        * demangle.h (enum demangle_component_type): Add        DEMANGLE_COMPONENT_CLONE. libiberty/ChangeLog:        PR 40831        * cp-demangle.c (d_make_comp): Add new component type.  

Re: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-01 Thread Cary Coutant
Ping? http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html -cary On Fri, Aug 19, 2011 at 5:57 PM, Cary Coutant wrote: >> OK, thanks. Dmitry G. also commented that the patch does not work "for >> `_Z3fooi.1988' or `_Z3fooi.part.9.165493.constprop.775.31805'." >> Apparently, there can be multi

Re: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-08-19 Thread Cary Coutant
> OK, thanks. Dmitry G. also commented that the patch does not work "for > `_Z3fooi.1988' or `_Z3fooi.part.9.165493.constprop.775.31805'." > Apparently, there can be multiple numeric suffixes, and a cloned > function can be cloned again. Is it worth trying to identify the kinds > of cloning in the