Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-04-01 Thread Ian Lance Taylor
Rainer Orth writes: > Ian Lance Taylor writes: > >> Thanks. I'm going to try gambling that every uses the type "long" for >> the fds_bits array. If so, I think this patch will work. Bootstrapped >> and ran Go testsuite on x86_64-unknown-linux-gnu (forcing the use of >> select). Committed to

Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-04-01 Thread Rainer Orth
Ian Lance Taylor writes: > Thanks. I'm going to try gambling that every uses the type "long" for > the fds_bits array. If so, I think this patch will work. Bootstrapped > and ran Go testsuite on x86_64-unknown-linux-gnu (forcing the use of > select). Committed to mainline. I fear you lost ;-

Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-03-31 Thread Ian Lance Taylor
Rainer Orth writes: > While debugging why several libgo tests on Solaris 2/SPARC were hanging > in select (cf. PR go/48242, go/48243), I found that fd_set is > > typedef struct fd_set { > longfds_bits[__howmany(FD_SETSIZE, FD_NFDBITS)]; > } fd_set; > > The current implementation of th

Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-03-31 Thread Ian Lance Taylor
Richard Henderson writes: > On 03/31/2011 09:03 AM, Ian Lance Taylor wrote: >> What an annoying problem. Sorry about that. But why don't we just >> change to byte? > > That would work for little-endian, but not big-endian, at least not > without even worse ugliness in two different files. Yeah

Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-03-31 Thread Richard Henderson
On 03/31/2011 09:03 AM, Ian Lance Taylor wrote: > What an annoying problem. Sorry about that. But why don't we just > change to byte? That would work for little-endian, but not big-endian, at least not without even worse ugliness in two different files. r~

Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-03-31 Thread Rainer Orth
Ian Lance Taylor writes: > What an annoying problem. Sorry about that. But why don't we just > change to byte? If this causes the right bits to be set for big and little-endian hosts, certainly fine with me. I haven't tried yet, but the less different code paths, the better. Rainer

Re: [libgo] Account for 32-bit fds_bits on Solaris 2

2011-03-31 Thread Ian Lance Taylor
Rainer Orth writes: > While debugging why several libgo tests on Solaris 2/SPARC were hanging > in select (cf. PR go/48242, go/48243), I found that fd_set is > > typedef struct fd_set { > longfds_bits[__howmany(FD_SETSIZE, FD_NFDBITS)]; > } fd_set; > > The current implementation of th

[libgo] Account for 32-bit fds_bits on Solaris 2

2011-03-31 Thread Rainer Orth
While debugging why several libgo tests on Solaris 2/SPARC were hanging in select (cf. PR go/48242, go/48243), I found that fd_set is typedef struct fd_set { longfds_bits[__howmany(FD_SETSIZE, FD_NFDBITS)]; } fd_set; The current implementation of the FD* funcs in sysfile_posix.go assu