Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 04:59:43PM -0500, Sebastian Pop wrote: > >>> +  { > >>> +    isl_dim *dc = isl_set_get_dim (scop->context); > >>> +    int nb_in = isl_dim_size (dc, isl_dim_set); > >>> +    int nb_out = 1 + DR_NUM_DIMENSIONS (dr); > >>> +    int nbp = scop_nb_params (scop); > >>> +    isl_d

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
>>> +  { >>> +    isl_dim *dc = isl_set_get_dim (scop->context); >>> +    int nb_in = isl_dim_size (dc, isl_dim_set); >>> +    int nb_out = 1 + DR_NUM_DIMENSIONS (dr); >>> +    int nbp = scop_nb_params (scop); >>> +    isl_dim *dim = isl_dim_alloc (scop->ctx, nbp, nb_in, nb_out); >>> +    int i; >>

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 16:00, Sven Verdoolaege wrote: > On Thu, Aug 11, 2011 at 03:10:30PM -0500, Sebastian Pop wrote: >> On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege wrote: >> > On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: >> >> + >> >> +  /* FIXME: This function will be re

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 03:23:13PM -0500, Sebastian Pop wrote: > As we are using this function only on parameters, get_name should > return a unique name. I guess that the name in isl_id is only used > for debugging purposes, as the ISL manual states that "Identifiers > with the same name but diff

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 03:10:30PM -0500, Sebastian Pop wrote: > On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege wrote: > > On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: > >> + > >> +  /* FIXME: This function will be renamed isl_map_insert_dims and > >> +     documented in a later

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 08:14:05PM +0100, Tobias Grosser wrote: > I think the best would be to provide our ctx to cloog when allocating > the CloogState. Yes. skimo

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 14:14, Tobias Grosser wrote: > This needs to be adapted to my cloog.org interface patch. I will adapt my patch set to be on top of your patch. >> +/* Return an ISL identifier from the name of the ssa_name E.  */ >> + >> +static isl_id * >> +isl_id_for_ssa_name (scop_p s,

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege wrote: > On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: >> +  if (1) >> +    { >> +      /* For now remove the isl_id's from the context before >> +      translating to CLooG: this code will be removed when the >> +      domain will a

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: > + if (1) > +{ > + /* For now remove the isl_id's from the context before > + translating to CLooG: this code will be removed when the > + domain will also contain isl_id's. */ > + isl_set *context = isl_set_p

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Tobias Grosser
On 08/11/2011 07:16 PM, Sebastian Pop wrote: On Thu, Aug 11, 2011 at 13:03, Sebastian Pop wrote: > On Thu, Aug 11, 2011 at 12:52, Tobias Grosser wrote: >> I will commit this patch after the configure changes are in (and meanwhile >> no further improvements were suggested for this patch).

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Tobias Grosser
On 08/11/2011 07:03 PM, Sebastian Pop wrote: On Thu, Aug 11, 2011 at 12:52, Tobias Grosser wrote: I will commit this patch after the configure changes are in (and meanwhile no further improvements were suggested for this patch). Ok, thanks. Let's hope we will have a configure maintainer that

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 12:52, Tobias Grosser wrote: > I will commit this patch after the configure changes are in (and meanwhile > no further improvements were suggested for this patch). Ok, thanks. Let's hope we will have a configure maintainer that has some spare cycles to go over your first

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Tobias Grosser
On 08/10/2011 11:41 PM, Sebastian Pop wrote: Hi Tobi, The patch looks good modulo some formatting changes: Thanks for your review. I attached the updated patch. I will commit this patch after the configure changes are in (and meanwhile no further improvements were suggested for this patch).

Re: [graphite] Move to cloog.org interface

2011-08-10 Thread Sebastian Pop
Hi Tobi, The patch looks good modulo some formatting changes: +free(c->free_name); + int length = strlen(e->name); [...] Please follow the GNU style: there should be a space between the function name and the open parenthesis. - dom = new_Cloog_Domain_from_ppl_Pointset_Powerset (PBB_DO

[graphite] Move to cloog.org interface

2011-08-10 Thread Tobias Grosser
Hi, this patch moves the graphite code to the documented cloog library interface and removes the use of old/deprecated interfaces. It ensures that graphite will also compile flawless with future cloog.org versions. * graphite-clast-to-gimple.c (new_clast_name_index): Store a copy of the s