Re: [google] dump inline decisions to stderr under -fopt-info

2011-12-15 Thread Xinliang David Li
Looks good in general. 1) The profile information should be omitted when profile information is not available 2) have a test case showing the call chain. Ok for google branches with the above changes. thanks, David On Thu, Dec 15, 2011 at 12:30 AM, Dehao Chen wrote: > I change to use the bfd_

Re: [google] dump inline decisions to stderr under -fopt-info

2011-12-15 Thread Dehao Chen
I change to use the bfd_name, which is much shorter for C++ symbols. Thanks, Dehao On Thu, Dec 15, 2011 at 2:07 AM, Xinliang David Li wrote: > Another usability related issue for C++. The long demangled function > names will make the info messages very hard to swallow. Since there > will be sour

Re: [google] dump inline decisions to stderr under -fopt-info

2011-12-14 Thread Xinliang David Li
Another usability related issue for C++. The long demangled function names will make the info messages very hard to swallow. Since there will be source lines to show the source context, it might be better to just use the short decl names. The downside is it can be ambiguous for template functions.

Re: [google] dump inline decisions to stderr under -fopt-info

2011-12-13 Thread Xinliang David Li
There are a couple of problems with the patch (the patch is only compatible with 4_6 branch) 1) the dump_inline_decision should be called inside cgraph_mark_inline_edge when the edge is finally picked (and when the callee node is cloned) 2) The source location is not printed which makes the dumpin

Re: [google] dump inline decisions to stderr under -fopt-info

2011-12-13 Thread Dehao Chen
Sorry, forgot to attach the patch... Dehao On Wed, Dec 14, 2011 at 9:13 AM, Dehao Chen wrote: > I've updated the patch to fix a bug in dump_inline_decision. > > Thanks, > Dehao > > On Thu, Dec 1, 2011 at 9:59 AM, Dehao Chen wrote: >> >> This patch is for google-{main|gcc_4.6} only. >> >> Tested

Re: [google] dump inline decisions to stderr under -fopt-info

2011-12-13 Thread Dehao Chen
I've updated the patch to fix a bug in dump_inline_decision. Thanks, Dehao On Thu, Dec 1, 2011 at 9:59 AM, Dehao Chen wrote: > > This patch is for google-{main|gcc_4.6} only. > > Tested with bootstrap and regression tests. > > Dump inline decisions, also output the inline chain. > > Dehao > > 20

[google] dump inline decisions to stderr under -fopt-info

2011-11-30 Thread Dehao Chen
This patch is for google-{main|gcc_4.6} only. Tested with bootstrap and regression tests. Dump inline decisions, also output the inline chain. Dehao 2011-12-01 Dehao Chen * ipa-inline.c (dump_inline_decision): New function. (inline_small_functions): Use it to dump the inline