Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-10-14 Thread Rong Xu
. Let me know you cannot find it. We do plan to submit to trunk for both gcc and kernel changes. But we don't expect it happens shortly. -Rong> From: vulcansh > Date: Fri, Oct 14, 2011 at 2:53 PM > Subject: Re: [google] support for building Linux kernel with FDO > (issue4523061)

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-10-14 Thread vulcansh
I found this thread through a Google search so I didn't have much context. Can you point me to the google/main source repo for gcc and the kernel? Are there plans to migrate this patch to the gcc and Linux mainline? Sorry, but I have never used the PGO option in icc. Steve Xinliang David Li

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-10-13 Thread Xinliang David Li
This patch is for google/main which is 4.7 based, but the validated version is in google_46 branch (which is based on 4.6). By the way (given that you are from intel), do you know if linux kernel can be built with icc with PGO turned on? Our intern Xiaotian has tried to use icc (12.0) to built ke

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-10-13 Thread vulcansh
Rong Xu wrote: > > That will be good. > But you never know, we internally have fixed some bugs that filed to > us because people use kernel's old gcov code (many versions guarded by > ifdef) for their tests. > > -Rong > Has there been any progress one this patch? What version of gcc is this

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Rong Xu
That will be good. But you never know, we internally have fixed some bugs that filed to us because people use kernel's old gcov code (many versions guarded by ifdef) for their tests. -Rong On Mon, May 16, 2011 at 4:23 PM, Andi Kleen wrote: > Rong Xu writes: > >>> The current kernel code is for

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Rong Xu
On Sun, May 15, 2011 at 3:27 AM, Jan Hubicka wrote: >> On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: >> > On 05/13/2011 03:03 AM, Rong Xu wrote: >> >> >> >>        * gcc/coverage.c        (revision 173717): set a flag if building >> >> for Linux kernel. >> >>        * gcc/tree-profile.c  

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Andi Kleen
Rong Xu writes: >> The current kernel code is for gcc 3. That could be simply >> replaced with a modern gcc 4 interface. > > You cannot replace. You have to keep the code for every gcc versions > that being used. I don't think it's a problem to not support gcc 3 gcov/profiling anymore. -Andi -

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Jan Hubicka
> On Mon, May 16, 2011 at 3:38 PM, Andi Kleen wrote: > > Jan Hubicka writes: > >> Yep, > >> I think it does make sense to share the implementation, but we need to find > >> resonable way to do so. > > > > I doubt this will be very popular with the kernel community, which > > prefers self containe

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Xinliang David Li
On Mon, May 16, 2011 at 3:38 PM, Andi Kleen wrote: > Jan Hubicka writes: >> Yep, >> I think it does make sense to share the implementation, but we need to find >> resonable way to do so. > > I doubt this will be very popular with the kernel community, which > prefers self contained code. Won't b

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Rong Xu
On Mon, May 16, 2011 at 3:38 PM, Andi Kleen wrote: > Jan Hubicka writes: >> Yep, >> I think it does make sense to share the implementation, but we need to find >> resonable way to do so. > > I doubt this will be very popular with the kernel community, which > prefers self contained code. > > Also

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Andi Kleen
Jan Hubicka writes: > Yep, > I think it does make sense to share the implementation, but we need to find > resonable way to do so. I doubt this will be very popular with the kernel community, which prefers self contained code. Also the interface doesn't change that often or does it? The curren

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-16 Thread Xinliang David Li
Agreed. David On Sun, May 15, 2011 at 3:27 AM, Jan Hubicka wrote: >> On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: >> > On 05/13/2011 03:03 AM, Rong Xu wrote: >> >> >> >>        * gcc/coverage.c        (revision 173717): set a flag if building >> >> for Linux kernel. >> >>        * gcc/

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-15 Thread Jan Hubicka
> On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: > > On 05/13/2011 03:03 AM, Rong Xu wrote: > >> > >>        * gcc/coverage.c        (revision 173717): set a flag if building > >> for Linux kernel. > >>        * gcc/tree-profile.c    (revision 173717): don't emit TLS > >> declarations for L

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Rong Xu
Thanks for the comments. This particular patch is not intended for trunk. But we do want to hear your feedback on our designs. On Fri, May 13, 2011 at 9:31 AM, Xinliang David Li wrote: > On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: >> On 05/13/2011 03:03 AM, Rong Xu wrote: >>> >>>      

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Rong Xu
Thanks for the comments. This particular patch is not intended for trunk. But we do want to hear your feedback on our designs. On Fri, May 13, 2011 at 9:31 AM, Xinliang David Li wrote: > On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: >> On 05/13/2011 03:03 AM, Rong Xu wrote: >>> >>>      

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Paolo Bonzini
On 05/13/2011 06:31 PM, Xinliang David Li wrote: > 1) add a new TLS model -ftls-model=none and make the kernel uses it. The > model would simply force targetm.have_tls to false. > This is a good idea. > 2) as Richi mentioned, gcov-io and libgcov changes then can move to the > kernel, and

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Xinliang David Li
On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: > On 05/13/2011 03:03 AM, Rong Xu wrote: >> >>        * gcc/coverage.c        (revision 173717): set a flag if building >> for Linux kernel. >>        * gcc/tree-profile.c    (revision 173717): don't emit TLS >> declarations for Linux kernel bu

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Andi Kleen
On Fri, May 13, 2011 at 11:43:42AM +0200, Jan Hubicka wrote: > > On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li > > wrote: > > > Ok for google/main. > > > > Seems to be very special and not appropriate for GCC trunk. Instead > > an adjusted copy providing the interface GCC needs should belo

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Paolo Bonzini
On 05/13/2011 03:03 AM, Rong Xu wrote: * gcc/coverage.c(revision 173717): set a flag if building for Linux kernel. * gcc/tree-profile.c(revision 173717): don't emit TLS declarations for Linux kernel builds. I think this should be done without touching at all the pr

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Jan Hubicka
> On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li wrote: > > Ok for google/main. > > Seems to be very special and not appropriate for GCC trunk. Instead > an adjusted copy providing the interface GCC needs should belong to > the kernel tree. Andi Kleen also did work in this direction. We prob

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li wrote: > Ok for google/main. Seems to be very special and not appropriate for GCC trunk. Instead an adjusted copy providing the interface GCC needs should belong to the kernel tree. Richard.

[google] support for building Linux kernel with FDO (issue4523061)

2011-05-12 Thread Rong Xu
This patch add support to build Linux kernel with FDO. Building Linux kernel with FDO needs both compiler change and kernel changes. This part only contains the gcc changes. I'll attach kernel changes to the reveiew thread for reference. Source files gcov-io.c gcov-io.h and libgcov.c will be