Re: [google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Teresa Johnson
The issue is that building the instrumented binary with and without, say, -gmlt, may result in different module grouping. Teresa On Fri, Sep 27, 2013 at 1:18 PM, Rong Xu wrote: > I don't quite understand here. We use the profile-generate memory > consumption to estimate the profile use memory co

Re: [google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Xinliang David Li
The key is that grouping results should not dependent on the presence of -g flags. The downside of the patch is that it may slightly underestimate the memory pressure at profile-use time, but that should not be a big problem. David On Fri, Sep 27, 2013 at 1:18 PM, Rong Xu wrote: > I don't quite

Re: [google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Rong Xu
I don't quite understand here. We use the profile-generate memory consumption to estimate the profile use memory consumption. we still have -g/-gmlt in profile-use compilation. Will this change effectively under estimate the memory use in the use phrase? -Rong On Fri, Sep 27, 2013 at 11:50 AM, Te

Re: [google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Xinliang David Li
ok. David On Fri, Sep 27, 2013 at 1:03 PM, Teresa Johnson wrote: > On Fri, Sep 27, 2013 at 12:01 PM, Xinliang David Li > wrote: >> On Fri, Sep 27, 2013 at 11:50 AM, Teresa Johnson >> wrote: >>> David and Rong, >>> >>> The following patch will disable -g/-gmlt when instrumenting for LIPO >>>

Re: [google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Teresa Johnson
On Fri, Sep 27, 2013 at 12:01 PM, Xinliang David Li wrote: > On Fri, Sep 27, 2013 at 11:50 AM, Teresa Johnson wrote: >> David and Rong, >> >> The following patch will disable -g/-gmlt when instrumenting for LIPO >> since they will affect the recorded ggc_memory used in the module >> grouping deci

Re: [google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Xinliang David Li
On Fri, Sep 27, 2013 at 11:50 AM, Teresa Johnson wrote: > David and Rong, > > The following patch will disable -g/-gmlt when instrumenting for LIPO > since they will affect the recorded ggc_memory used in the module > grouping decision. Added -fripa-allow-debug to override this behavior. > > Passe

[google/4_8] Disable -g/-gmlt during LIPO instrumentation

2013-09-27 Thread Teresa Johnson
David and Rong, The following patch will disable -g/-gmlt when instrumenting for LIPO since they will affect the recorded ggc_memory used in the module grouping decision. Added -fripa-allow-debug to override this behavior. Passes regression tests and simple tests on the new functionality. Ok for