Re: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread Jakub Jelinek
On Wed, Mar 23, 2016 at 08:05:19AM -0500, James Norris wrote: > Jakub, > > On 03/23/2016 05:24 AM, Jakub Jelinek wrote: > >Otherwise LGTM, but please repost it with all the testcase changes you want > >to make. > > Attached is the updated patch with the castings added, as well as > the updated te

Re: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread James Norris
Jakub, On 03/23/2016 05:24 AM, Jakub Jelinek wrote: Otherwise LGTM, but please repost it with all the testcase changes you want to make. Attached is the updated patch with the castings added, as well as the updated tests. Thanks! Jim == 2016-03-23 James Norris Daichi Fuku

RE: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread Fukuoka Daichi
y, March 23, 2016 7:37 PM To: Fukuoka Daichi Cc: James Norris; Thomas Schwinge; GCC Patches Subject: Re: [gomp4] Fix handling of subarrays with update directive On Wed, Mar 23, 2016 at 10:31:33AM +, Fukuoka Daichi wrote: > > Yeah, the oacc-mem.c is a two liner, we don't need co

Re: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread Jakub Jelinek
On Wed, Mar 23, 2016 at 10:31:33AM +, Fukuoka Daichi wrote: > > Yeah, the oacc-mem.c is a two liner, we don't need copyright assignment for > > that, so please mention Daichi-san's name + mail address, and PR > > libgpmp/69414 in the ChangeLog entry. > > If possible, could you add " SGI Japa

RE: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread Fukuoka Daichi
I am belonging to the company. Thank you. Regards, Daichi Fukuoka -Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Wednesday, March 23, 2016 7:24 PM To: Thomas Schwinge Cc: James Norris; GCC Patches; Fukuoka Daichi Subject: Re: [gomp4] Fix handling of subarrays with

Re: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread Jakub Jelinek
On Wed, Mar 23, 2016 at 09:35:30AM +0100, Thomas Schwinge wrote: > Hi! > > On Fri, 22 Jan 2016 12:50:38 -0600, James Norris > wrote: > > The attached patch fixes a defect reported with gcc 5.2 > > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69414). > > It is also the case, the issue is present

Re: [gomp4] Fix handling of subarrays with update directive

2016-03-23 Thread Thomas Schwinge
Hi! On Fri, 22 Jan 2016 12:50:38 -0600, James Norris wrote: > The attached patch fixes a defect reported with gcc 5.2 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69414). > It is also the case, the issue is present in the gomp4 > branch. The patch also adds additional testing. > > Committed

[gomp4] Fix handling of subarrays with update directive

2016-01-22 Thread James Norris
Hi, The attached patch fixes a defect reported with gcc 5.2 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69414). It is also the case, the issue is present in the gomp4 branch. The patch also adds additional testing. Committed to gomp4 after bootstrap and regtesting. Thanks, Jim Index: ChangeL