On Wed, Nov 5, 2014 at 4:55 AM, Dominik Vogt wrote:
> On Wed, Nov 05, 2014 at 11:31:28AM +0100, Dominik Vogt wrote:
>> On Tue, Nov 04, 2014 at 02:39:34PM -0800, Ian Taylor wrote:
>> > Note that libgo/runtime/runtime.c now refers to S390_HAVE_STCKF. It's
>> > not obvious to me that that is defined
On Thu, Nov 6, 2014 at 7:34 AM, Dominik Vogt wrote:
> On Thu, Nov 06, 2014 at 03:02:13PM +0100, Rainer Orth wrote:
>> Ian Taylor writes:
>> > Committed patch 0001 with various formatting fixes, as attached.
>>
>> Unfortunately, the mksysinfo.sh part broke Solaris bootstrap: there's no
>> type _uc
On Thu, Nov 06, 2014 at 03:02:13PM +0100, Rainer Orth wrote:
> Ian Taylor writes:
> > Committed patch 0001 with various formatting fixes, as attached.
>
> Unfortunately, the mksysinfo.sh part broke Solaris bootstrap: there's no
> type _ucred in gen-sysinfo.go, so the grep in upcase_fields fails.
Ian Taylor writes:
> On Tue, Nov 4, 2014 at 4:15 AM, Dominik Vogt wrote:
>> See commit comment and ChangeLog for details.
>
> Committed patch 0001 with various formatting fixes, as attached.
Unfortunately, the mksysinfo.sh part broke Solaris bootstrap: there's no
type _ucred in gen-sysinfo.go,
On Wed, Nov 05, 2014 at 11:31:28AM +0100, Dominik Vogt wrote:
> On Tue, Nov 04, 2014 at 02:39:34PM -0800, Ian Taylor wrote:
> > Note that libgo/runtime/runtime.c now refers to S390_HAVE_STCKF. It's
> > not obvious to me that that is defined anywhere. Perhaps it is in a
> > later patch in this ser
On Tue, Nov 04, 2014 at 02:39:34PM -0800, Ian Taylor wrote:
> Note that libgo/runtime/runtime.c now refers to S390_HAVE_STCKF. It's
> not obvious to me that that is defined anywhere. Perhaps it is in a
> later patch in this series--I haven't looked.
This chunk is broken but harmless (because S39
On Tue, Nov 4, 2014 at 4:15 AM, Dominik Vogt wrote:
> See commit comment and ChangeLog for details.
Committed patch 0001 with various formatting fixes, as attached.
Note that libgo/runtime/runtime.c now refers to S390_HAVE_STCKF. It's
not obvious to me that that is defined anywhere. Perhaps it
On Tue, Nov 4, 2014 at 4:15 AM, Dominik Vogt wrote:
> See commit comment and ChangeLog for details.
> case "amd64", "386":
> + case "s390", "s390x":
Note that this doesn't do what you want. In Go, unlike C, cases do
not fall through by default. So doing this means that the amd64 and
