Re: [driver] Use regular error routines

2018-09-11 Thread Nathan Sidwell
On 9/11/18 3:58 PM, Joseph Myers wrote: I'd expect all the cases where you pass a string containing '%s' to the generic diagnostic functions to use %qs instead of '%s' for quoting, to get appropriate locale-specific quotes. yes of course, slipped my mind. Committed the attached after manual te

Re: [driver] Use regular error routines

2018-09-11 Thread Joseph Myers
I'd expect all the cases where you pass a string containing '%s' to the generic diagnostic functions to use %qs instead of '%s' for quoting, to get appropriate locale-specific quotes. -- Joseph S. Myers jos...@codesourcery.com

[driver] Use regular error routines

2018-09-11 Thread Nathan Sidwell
The driver gcc.c has 2 internal error reporting routines perror_with_name & pfatal_with_name, which take a single string argument. Firstly the latter forwards to the former, then calls exit after doing some cleanup. However, that cleanup is already registered via atexit, so it'll get done any