Re: [committed] libstdc++: Fix value categories used by ranges access CPOs [PR 100824]

2021-06-05 Thread Jonathan Wakely via Gcc-patches
On 04/06/21 21:46 +0100, Jonathan Wakely wrote: On 04/06/21 21:44 +0100, Jonathan Wakely wrote: On 04/06/21 18:03 +0100, Jonathan Wakely wrote: The implementation of P2091R0 was incomplete, so that some range access CPOs used perfect forwarding where they should not. This fixes it by consistent

Re: [committed] libstdc++: Fix value categories used by ranges access CPOs [PR 100824]

2021-06-04 Thread Jonathan Wakely via Gcc-patches
On 04/06/21 21:44 +0100, Jonathan Wakely wrote: On 04/06/21 18:03 +0100, Jonathan Wakely wrote: The implementation of P2091R0 was incomplete, so that some range access CPOs used perfect forwarding where they should not. This fixes it by consistently operating on lvalues. Some additional changes

Re: [committed] libstdc++: Fix value categories used by ranges access CPOs [PR 100824]

2021-06-04 Thread Jonathan Wakely via Gcc-patches
On 04/06/21 18:03 +0100, Jonathan Wakely wrote: The implementation of P2091R0 was incomplete, so that some range access CPOs used perfect forwarding where they should not. This fixes it by consistently operating on lvalues. Some additional changes that are not necessary to fix the bug: Modify t

[committed] libstdc++: Fix value categories used by ranges access CPOs [PR 100824]

2021-06-04 Thread Jonathan Wakely via Gcc-patches
The implementation of P2091R0 was incomplete, so that some range access CPOs used perfect forwarding where they should not. This fixes it by consistently operating on lvalues. Some additional changes that are not necessary to fix the bug: Modify the __as_const helper to simplify its usage. Instea