Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Christophe Lyon
On 6 January 2017 at 12:39, Richard Biener wrote: > On January 6, 2017 11:21:44 AM GMT+01:00, Jakub Jelinek > wrote: >>On Fri, Jan 06, 2017 at 09:34:46AM +0100, Christophe Lyon wrote: >>> I makes my aarch64*linux* and arm*linux* builds for fail, because: >>> gcc/fortran/simplify.c:613: error: #p

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Jeff Law
On 01/06/2017 04:39 AM, Richard Biener wrote: On January 6, 2017 11:21:44 AM GMT+01:00, Jakub Jelinek wrote: On Fri, Jan 06, 2017 at 09:34:46AM +0100, Christophe Lyon wrote: I makes my aarch64*linux* and arm*linux* builds for fail, because: gcc/fortran/simplify.c:613: error: #pragma GCC diagn

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Jeff Law
On 01/06/2017 04:34 AM, Christophe Lyon wrote: On 6 January 2017 at 11:21, Jakub Jelinek wrote: On Fri, Jan 06, 2017 at 09:34:46AM +0100, Christophe Lyon wrote: I makes my aarch64*linux* and arm*linux* builds for fail, because: gcc/fortran/simplify.c:613: error: #pragma GCC diagnostic not allo

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Richard Biener
On January 6, 2017 11:21:44 AM GMT+01:00, Jakub Jelinek wrote: >On Fri, Jan 06, 2017 at 09:34:46AM +0100, Christophe Lyon wrote: >> I makes my aarch64*linux* and arm*linux* builds for fail, because: >> gcc/fortran/simplify.c:613: error: #pragma GCC diagnostic not allowed >> inside functions >> gc

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Christophe Lyon
On 6 January 2017 at 11:21, Jakub Jelinek wrote: > On Fri, Jan 06, 2017 at 09:34:46AM +0100, Christophe Lyon wrote: >> I makes my aarch64*linux* and arm*linux* builds for fail, because: >> gcc/fortran/simplify.c:613: error: #pragma GCC diagnostic not allowed >> inside functions >> gcc/fortran/simp

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Jakub Jelinek
On Fri, Jan 06, 2017 at 09:34:46AM +0100, Christophe Lyon wrote: > I makes my aarch64*linux* and arm*linux* builds for fail, because: > gcc/fortran/simplify.c:613: error: #pragma GCC diagnostic not allowed > inside functions > gcc/fortran/simplify.c:620: error: #pragma GCC diagnostic not allowed >

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-06 Thread Christophe Lyon
Hi Alexandre, On 6 January 2017 at 04:27, Alexandre Oliva wrote: > On Jan 5, 2017, Jeff Law wrote: > >> On 01/05/2017 05:15 AM, Richard Biener wrote: >>> Reasonable -- I'll leave it for others to comment on that "standard >>> practice" part (it'll be the first case of using this IIRC). > >> It'

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-05 Thread Alexandre Oliva
On Jan 5, 2017, Jeff Law wrote: > On 01/05/2017 05:15 AM, Richard Biener wrote: >> Reasonable -- I'll leave it for others to comment on that "standard >> practice" part (it'll be the first case of using this IIRC). > It's a fair amount of clutter. But I won't object. I'll take these as a tent

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-05 Thread Jeff Law
On 01/05/2017 05:15 AM, Richard Biener wrote: On Thu, Jan 5, 2017 at 5:06 AM, Alexandre Oliva wrote: On Jan 4, 2017, Alexandre Oliva wrote: I'll prepare and post a patch anyway, but do we want to make it standard practice? Here it is. simplify_transformation_to_array had the nested loop

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-05 Thread Richard Biener
On Thu, Jan 5, 2017 at 5:06 AM, Alexandre Oliva wrote: > On Jan 4, 2017, Alexandre Oliva wrote: > >> I'll prepare and post a patch anyway, but do we want to make it >> standard practice? > > Here it is. > > simplify_transformation_to_array had the nested loop unrolled 7 times, > which is reasona

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-04 Thread Alexandre Oliva
On Jan 4, 2017, Alexandre Oliva wrote: > I'll prepare and post a patch anyway, but do we want to make it > standard practice? Here it is. simplify_transformation_to_array had the nested loop unrolled 7 times, which is reasonable given that it iterates over arrays of size GFC_MAX_DIMENSIONS ==

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-04 Thread Alexandre Oliva
On Jan 4, 2017, Richard Biener wrote: >> Unfortunately I don't have another that silences the warning without >> (or even with) impact on codegen. > #pragma GCC diagnostic push ("Wno-array-bounds") > #pragma GCC diagnostic pop Wwwhaaat? #pragma GCC diagnostic to silence warnings? Who'd have

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-04 Thread Richard Biener
On Wed, Jan 4, 2017 at 2:23 PM, Alexandre Oliva wrote: > On Jan 4, 2017, Richard Biener wrote: > >> On Tue, Jan 3, 2017 at 7:19 PM, Jeff Law wrote: >>> On 01/02/2017 10:29 PM, Alexandre Oliva wrote: * simplify.c (simplify_transformation_to_array): Assert the array access is in range.

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-04 Thread Alexandre Oliva
On Jan 4, 2017, Richard Biener wrote: > On Tue, Jan 3, 2017 at 7:19 PM, Jeff Law wrote: >> On 01/02/2017 10:29 PM, Alexandre Oliva wrote: >>> * simplify.c (simplify_transformation_to_array): Assert the >>> array access is in range. Fix whitespace. > But once we default to release checking it

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-04 Thread Richard Biener
On Tue, Jan 3, 2017 at 7:19 PM, Jeff Law wrote: > On 01/02/2017 10:29 PM, Alexandre Oliva wrote: >> >> simplify_transformation_to_array had the nested loop unrolled 7 times, >> which is reasonable given that it iterates over arrays of size >> GFC_MAX_DIMENSIONS == 7. >> >> The problem is that the

Re: [bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-03 Thread Jeff Law
On 01/02/2017 10:29 PM, Alexandre Oliva wrote: simplify_transformation_to_array had the nested loop unrolled 7 times, which is reasonable given that it iterates over arrays of size GFC_MAX_DIMENSIONS == 7. The problem is that the last iteration increments the index, tests that it's less than res

[bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

2017-01-02 Thread Alexandre Oliva
simplify_transformation_to_array had the nested loop unrolled 7 times, which is reasonable given that it iterates over arrays of size GFC_MAX_DIMENSIONS == 7. The problem is that the last iteration increments the index, tests that it's less than result->rank, and then accesses the arrays with the