Re: [asan] Protection of stack vars (take 3)

2012-10-17 Thread Diego Novillo
On 2012-10-17 05:35 , Jakub Jelinek wrote: 2012-10-17 Jakub Jelinek * Makefile.in (asan.o): Depend on $(EXPR_H) $(OPTABS_H). (cfgexpand.o): Depend on asan.h. * asan.c: Include expr.h and optabs.h. (asan_shadow_set): New variable. (asan_shadow_cst, asan

Re: [asan] Protection of stack vars (take 3)

2012-10-17 Thread Xinliang David Li
Looks ok to me for the branch. thanks, David On Wed, Oct 17, 2012 at 2:35 AM, Jakub Jelinek wrote: > On Tue, Oct 16, 2012 at 03:56:31PM -0700, Xinliang David Li wrote: >> >> 1) I am not sure if the stack slot sharing is handled correctly. If I >> >> read the code correctly, the redzone var will

[asan] Protection of stack vars (take 3)

2012-10-17 Thread Jakub Jelinek
On Tue, Oct 16, 2012 at 03:56:31PM -0700, Xinliang David Li wrote: > >> 1) I am not sure if the stack slot sharing is handled correctly. If I > >> read the code correctly, the redzone var will be only created for the > >> representative variable in a partition -- will this lead to false > >> negati