Re: [RFC]rs6000: split complicated constant to memory

2022-08-16 Thread Jiufu Guo via Gcc-patches
Hi, Segher Boessenkool writes: > Hi! > > On Mon, Aug 15, 2022 at 01:25:19PM +0800, Jiufu Guo wrote: >> This patch tries to put the constant into constant pool if building the >> constant requires 3 or more instructions. >> >> But there is a concern: I'm wondering if this patch is really profi

Re: [RFC]rs6000: split complicated constant to memory

2022-08-15 Thread Jiufu Guo via Gcc-patches
Jiufu Guo writes: > Hi, > > Richard Biener writes: > >> On Mon, Aug 15, 2022 at 7:26 AM Jiufu Guo via Gcc-patches >> wrote: >>> >>> Hi, >>> >>> This patch tries to put the constant into constant pool if building the >>> constant requires 3 or more instructions. >>> >>> But there is a concern: I

Re: [RFC]rs6000: split complicated constant to memory

2022-08-15 Thread Jiufu Guo via Gcc-patches
Hi, Richard Biener writes: > On Mon, Aug 15, 2022 at 7:26 AM Jiufu Guo via Gcc-patches > wrote: >> >> Hi, >> >> This patch tries to put the constant into constant pool if building the >> constant requires 3 or more instructions. >> >> But there is a concern: I'm wondering if this patch is rea

Re: [RFC]rs6000: split complicated constant to memory

2022-08-15 Thread Segher Boessenkool
Hi! On Mon, Aug 15, 2022 at 01:25:19PM +0800, Jiufu Guo wrote: > This patch tries to put the constant into constant pool if building the > constant requires 3 or more instructions. > > But there is a concern: I'm wondering if this patch is really profitable. > > Because, as I tested, 1. for simp

Re: [RFC]rs6000: split complicated constant to memory

2022-08-15 Thread Richard Biener via Gcc-patches
On Mon, Aug 15, 2022 at 7:26 AM Jiufu Guo via Gcc-patches wrote: > > Hi, > > This patch tries to put the constant into constant pool if building the > constant requires 3 or more instructions. > > But there is a concern: I'm wondering if this patch is really profitable. > > Because, as I tested, 1

[RFC]rs6000: split complicated constant to memory

2022-08-14 Thread Jiufu Guo via Gcc-patches
Hi, This patch tries to put the constant into constant pool if building the constant requires 3 or more instructions. But there is a concern: I'm wondering if this patch is really profitable. Because, as I tested, 1. for simple case, if instructions are not been run in parallel, loading constant