Re: [RFC] Improve tree DSE

2018-05-14 Thread Jeff Law
On 05/01/2018 05:16 PM, Kugan Vivekanandarajah wrote: >> I'm also struggling a little bit to see much value in handling this >> case. In the included testcases we've got a memset in a loop where the >> args do not vary across the loop iterations and there are no reads from >> the memory location w

Re: [RFC] Improve tree DSE

2018-05-14 Thread Richard Biener
On Mon, May 14, 2018 at 5:32 AM, Kugan Vivekanandarajah wrote: > Hi Richard, > >>> Given the simple testcases you add I wonder if you want a cheaper >>> implementation, >>> namely check that when reaching a loop PHI the only aliasing stmt in >>> its use-chain >>> is the use_stmt you reached the PH

Re: [RFC] Improve tree DSE

2018-05-13 Thread Kugan Vivekanandarajah
Hi Richard, >> Given the simple testcases you add I wonder if you want a cheaper >> implementation, >> namely check that when reaching a loop PHI the only aliasing stmt in >> its use-chain >> is the use_stmt you reached the PHI from. That would avoid this and the >> tests >> for the store being

Re: [RFC] Improve tree DSE

2018-05-03 Thread Richard Biener
On Wed, May 2, 2018 at 7:39 PM, Jeff Law wrote: > On 05/02/2018 11:36 AM, Richard Biener wrote: >> On May 2, 2018 6:17:50 PM GMT+02:00, Jeff Law wrote: >>> On 05/02/2018 03:27 AM, Richard Biener wrote: On Tue, Apr 10, 2018 at 2:52 AM, Kugan Vivekanandarajah wrote: > I would like to

Re: [RFC] Improve tree DSE

2018-05-02 Thread Jeff Law
On 05/02/2018 11:36 AM, Richard Biener wrote: > On May 2, 2018 6:17:50 PM GMT+02:00, Jeff Law wrote: >> On 05/02/2018 03:27 AM, Richard Biener wrote: >>> On Tue, Apr 10, 2018 at 2:52 AM, Kugan Vivekanandarajah >>> wrote: I would like to queue this patch for stage1 review. In DSE, w

Re: [RFC] Improve tree DSE

2018-05-02 Thread Richard Biener
On May 2, 2018 6:17:50 PM GMT+02:00, Jeff Law wrote: >On 05/02/2018 03:27 AM, Richard Biener wrote: >> On Tue, Apr 10, 2018 at 2:52 AM, Kugan Vivekanandarajah >> wrote: >>> I would like to queue this patch for stage1 review. >>> >>> In DSE, while in dse_classify_store, as soon as we see a PHI use

Re: [RFC] Improve tree DSE

2018-05-02 Thread Jeff Law
On 05/02/2018 03:27 AM, Richard Biener wrote: > On Tue, Apr 10, 2018 at 2:52 AM, Kugan Vivekanandarajah > wrote: >> I would like to queue this patch for stage1 review. >> >> In DSE, while in dse_classify_store, as soon as we see a PHI use >> statement that is part of the loop, we are immediately g

Re: [RFC] Improve tree DSE

2018-05-02 Thread Richard Biener
On Tue, Apr 10, 2018 at 2:52 AM, Kugan Vivekanandarajah wrote: > I would like to queue this patch for stage1 review. > > In DSE, while in dse_classify_store, as soon as we see a PHI use > statement that is part of the loop, we are immediately giving up. > > As far as I understand, this can be impr

Re: [RFC] Improve tree DSE

2018-05-01 Thread Kugan Vivekanandarajah
Hi Jeff, Thanks for the review. On 2 May 2018 at 01:43, Jeff Law wrote: > On 04/09/2018 06:52 PM, Kugan Vivekanandarajah wrote: >> I would like to queue this patch for stage1 review. >> >> In DSE, while in dse_classify_store, as soon as we see a PHI use >> statement that is part of the loop, we

Re: [RFC] Improve tree DSE

2018-05-01 Thread Jeff Law
On 04/09/2018 06:52 PM, Kugan Vivekanandarajah wrote: > I would like to queue this patch for stage1 review. > > In DSE, while in dse_classify_store, as soon as we see a PHI use > statement that is part of the loop, we are immediately giving up. > > As far as I understand, this can be improved. At

[RFC] Improve tree DSE

2018-04-09 Thread Kugan Vivekanandarajah
I would like to queue this patch for stage1 review. In DSE, while in dse_classify_store, as soon as we see a PHI use statement that is part of the loop, we are immediately giving up. As far as I understand, this can be improved. Attached patch is trying to walk the uses of the PHI statement (by r