Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-19 Thread Uros Bizjak
On Thu, Dec 19, 2013 at 11:01 AM, Gopalasubramanian, Ganesh wrote: >> Please provide updated ChangeLog. > > --- gcc/ChangeLog (revision 206106) > +++ gcc/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2013-12-19 Ganesh Gopalasubramanian > + > + * config/i386/i386.c: Include cf

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-19 Thread Gopalasubramanian, Ganesh
> Please provide updated ChangeLog. --- gcc/ChangeLog (revision 206106) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,14 @@ +2013-12-19 Ganesh Gopalasubramanian + + * config/i386/i386.c: Include cfgloop.h. + (ix86_loop_memcount): New function. + (ix86_loop_unroll_ad

Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-11 Thread Uros Bizjak
On Wed, Dec 11, 2013 at 11:27 AM, Gopalasubramanian, Ganesh wrote: > Accommodated the changes that you mentioned. > Completed the bootstrap testing too. Please provide updated ChangeLog. The function comment is missing. Maybe you should also describe magic number 32 here? +static unsigned +ix86

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-11 Thread Gopalasubramanian, Ganesh
Guenther (richard.guent...@gmail.com) Subject: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4 On Wed, Dec 4, 2013 at 9:39 AM, Gopalasubramanian, Ganesh wrote: > Attached is the revised patch. > The target independent part has been already approved and added. > > This

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-04 Thread Gopalasubramanian, Ganesh
t: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4 On Wed, Dec 4, 2013 at 9:39 AM, Gopalasubramanian, Ganesh wrote: > Attached is the revised patch. > The target independent part has been already approved and added. > > This revision of the patch adds a x86 tune definit

Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-04 Thread Uros Bizjak
On Wed, Dec 4, 2013 at 9:39 AM, Gopalasubramanian, Ganesh wrote: > Attached is the revised patch. > The target independent part has been already approved and added. > > This revision of the patch adds a x86 tune definition and checks it while > deciding the unroll factor. > > Accommodated the co

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-12-04 Thread Gopalasubramanian, Ganesh
ard Guenther (richard.guent...@gmail.com); borntrae...@de.ibm.com; H.J. Lu (hjl.to...@gmail.com); Jakub Jelinek (ja...@redhat.com) Subject: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4 On Wed, Nov 20, 2013 at 7:26 PM, Gopalasubramanian, Ganesh wrote: > Steamroller proc

Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-28 Thread Richard Biener
r 22, 2013 1:46 PM > To: Gopalasubramanian, Ganesh > Cc: gcc-patches@gcc.gnu.org; Richard Guenther > (richard.guent...@gmail.com); borntrae...@de.ibm.com; H.J. Lu > (hjl.to...@gmail.com); Jakub Jelinek (ja...@redhat.com) > Subject: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and b

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-28 Thread Gopalasubramanian, Ganesh
atches@gcc.gnu.org; Richard Guenther (richard.guent...@gmail.com); borntrae...@de.ibm.com; H.J. Lu (hjl.to...@gmail.com); Jakub Jelinek (ja...@redhat.com) Subject: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4 On Wed, Nov 20, 2013 at 7:26 PM, Gopalasubramanian, Ganesh

Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-22 Thread Uros Bizjak
On Wed, Nov 20, 2013 at 7:26 PM, Gopalasubramanian, Ganesh wrote: > Steamroller processors contain a loop predictor and a loop buffer, which may > make unrolling small loops less important. > When unrolling small loops for steamroller, making the unrolled loop fit in > the loop buffer should be

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-21 Thread Gopalasubramanian, Ganesh
redhat.com) Subject: RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4 > I suggest you add this to x86-tune.def and enable it for > bdver3 and bdver4. The macro TARGET_LOOP_UNROLL_ADJUST is not new. It is already available and is used by target s390. Since it is not an "x86 o

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-20 Thread Gopalasubramanian, Ganesh
dhat.com) Subject: Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4 On Wed, Nov 20, 2013 at 10:26 AM, Gopalasubramanian, Ganesh wrote: > Hi, > > Steamroller processors contain a loop predictor and a loop buffer, which may > make unrolling small loops less important.

Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-20 Thread H.J. Lu
On Wed, Nov 20, 2013 at 10:26 AM, Gopalasubramanian, Ganesh wrote: > Hi, > > Steamroller processors contain a loop predictor and a loop buffer, which may > make unrolling small loops less important. > When unrolling small loops for steamroller, making the unrolled loop fit in > the loop buffer s

[RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-20 Thread Gopalasubramanian, Ganesh
Hi, Steamroller processors contain a loop predictor and a loop buffer, which may make unrolling small loops less important. When unrolling small loops for steamroller, making the unrolled loop fit in the loop buffer should be a priority. This patch uses a heuristic approach (number of memory re