Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-07 Thread Richard Sandiford
Jeff Law writes: > On 6/6/19 6:33 AM, Richard Sandiford wrote: >> Kugan Vivekanandarajah writes: >>> Hi Richard, >>> >>> On Thu, 6 Jun 2019 at 22:07, Richard Sandiford >>> wrote: Kugan Vivekanandarajah writes: > Hi Richard, > > On Thu, 6 Jun 2019 at 19:35, Richard Sandifor

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Jeff Law
On 6/6/19 6:33 AM, Richard Sandiford wrote: > Kugan Vivekanandarajah writes: >> Hi Richard, >> >> On Thu, 6 Jun 2019 at 22:07, Richard Sandiford >> wrote: >>> >>> Kugan Vivekanandarajah writes: Hi Richard, On Thu, 6 Jun 2019 at 19:35, Richard Sandiford wrote: > > Kug

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi Richard, > > On Thu, 6 Jun 2019 at 22:07, Richard Sandiford > wrote: >> >> Kugan Vivekanandarajah writes: >> > Hi Richard, >> > >> > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford >> > wrote: >> >> >> >> Kugan Vivekanandarajah writes: >> >> > Hi Richard, >>

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 6 Jun 2019 at 22:07, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > Hi Richard, > > > > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford > > wrote: > >> > >> Kugan Vivekanandarajah writes: > >> > Hi Richard, > >> > > >> > Thanks for the review. Attached is th

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi Richard, > > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford > wrote: >> >> Kugan Vivekanandarajah writes: >> > Hi Richard, >> > >> > Thanks for the review. Attached is the latest patch. >> > >> > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwp

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 6 Jun 2019 at 19:35, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > Hi Richard, > > > > Thanks for the review. Attached is the latest patch. > > > > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I > > am limiting fwprop in cases like th

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi Richard, > > Thanks for the review. Attached is the latest patch. > > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I > am limiting fwprop in cases like this. Is there a better fix for this? > index cf2c9de..2c99285 100644 > --- a/gcc/fwpr

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-05 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. Attached is the latest patch. For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I am limiting fwprop in cases like this. Is there a better fix for this? index cf2c9de..2c99285 100644 --- a/gcc/fwprop.c +++ b/gcc/fwprop.c @@ -1358,6 +1358,15 @@

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-03 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > index b3fae5b..ad838dd 100644 > --- a/gcc/tree-vect-loop-manip.c > +++ b/gcc/tree-vect-loop-manip.c > @@ -415,6 +415,7 @@ vect_set_loop_masks_directly (struct loop *loop, > loop_vec_info loop_v

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-02 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review, On Fri, 31 May 2019 at 19:43, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > @@ -609,8 +615,14 @@ vect_set_loop_masks_directly (struct loop *loop, > > loop_vec_info loop_vinfo, > > > >/* Get the mask value for the next iteration of th

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-31 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > @@ -609,8 +615,14 @@ vect_set_loop_masks_directly (struct loop *loop, > loop_vec_info loop_vinfo, > >/* Get the mask value for the next iteration of the loop. */ >next_mask = make_temp_ssa_name (mask_type, NULL, "next_mask"); > - gcall *cal

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-30 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Tue, 28 May 2019 at 20:44, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > [...] > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index b3fae5b..c15b8a2 100644 > > --- a/gcc/tree-vect-loop-manip.c > > +++ b/gcc/tr

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-28 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > [...] > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > index b3fae5b..c15b8a2 100644 > --- a/gcc/tree-vect-loop-manip.c > +++ b/gcc/tree-vect-loop-manip.c > @@ -415,10 +415,16 @@ vect_set_loop_masks_directly (struct loop *loop, > loop_vec_i

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-27 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Sat, 25 May 2019 at 19:41, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index 77d3dac..d6452a1 100644 > > --- a/gcc/tree-vect-loop-manip.c > > +++ b/gcc/tree-vect-lo

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-25 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > index 77d3dac..d6452a1 100644 > --- a/gcc/tree-vect-loop-manip.c > +++ b/gcc/tree-vect-loop-manip.c > @@ -418,7 +418,20 @@ vect_set_loop_masks_directly (struct loop *loop, > loop_vec_info loop_

[RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-21 Thread Kugan Vivekanandarajah
Hi, Attached RFC patch attempts to use 32-bit WHILELO in LP64 mode to fix the PR. Bootstarp and regression testing ongoing. In earlier testing, I ran into an issue related to fwprop. I will tackle that based on the feedback for the patch. Thanks, Kugan From 4e9837ff9c0c080923f342e83574a6fdba2b3d9