Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On 03.08.2017 18:04, Florian Weimer wrote: * Yuri Gribov: I've rebased the previous patch to trunk per Andrew's suggestion. Original patch description/motivation/questions are in https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01869.html What about the remaining TODOs? Yes, need to be fixed.

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Jeff Law
On 08/03/2017 11:03 AM, Florian Weimer wrote: > * Jeff Law: > >>> If speed is not a concern, but reliability is, call fork (the system >>> call, not glibc's wrapper which calls fork handlers) and do the work >>> in a single-threaded copy of the process. There, you can set up >>> signal handlers a

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Florian Weimer
* Yuri Gribov: > I've rebased the previous patch to trunk per Andrew's suggestion. > Original patch description/motivation/questions are in > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01869.html What about the remaining TODOs? > + if (__builtin_expect (msync ((void *)page, len, MS_ASYNC), 0

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Florian Weimer
* Jeff Law: >> If speed is not a concern, but reliability is, call fork (the system >> call, not glibc's wrapper which calls fork handlers) and do the work >> in a single-threaded copy of the process. There, you can set up >> signal handlers as you see fit, and the VM layout won't change >> unexp

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Jakub Jelinek
On Thu, Aug 03, 2017 at 09:48:47AM -0600, Jeff Law wrote: > > If speed is not a concern, but reliability is, call fork (the system > > call, not glibc's wrapper which calls fork handlers) and do the work > > in a single-threaded copy of the process. There, you can set up > > signal handlers as you

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 4:28 PM, H.J. Lu wrote: > On Thu, Aug 3, 2017 at 8:25 AM, Jeff Law wrote: >> On 08/03/2017 08:17 AM, Yury Gribov wrote: >>> On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov wrote: > On Thu, Aug 3, 2017 at 1:22 PM, H

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Jeff Law
On 08/02/2017 03:36 PM, Florian Weimer wrote: > * Jeff Law: > >> Something like setup a signal handler when we first start unwinding that >> flags the error and tear it down when we're done unwinding?Obviously >> we can't do setup/tear down each time for each address. Anyway, just >> thinking

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Jeff Law
On 08/03/2017 06:52 AM, Yury Gribov wrote: > On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: >> On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov >> wrote: >>> On 02.08.2017 23:04, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov wrote: > > On 02.08.2017 21:48, H.J. Lu

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread H.J. Lu
On Thu, Aug 3, 2017 at 8:25 AM, Jeff Law wrote: > On 08/03/2017 08:17 AM, Yury Gribov wrote: >> On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: >>> On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov >>> wrote: On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: > On Wed, Aug 2, 2017 at 9:29 PM, Yu

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Jeff Law
On 08/03/2017 08:17 AM, Yury Gribov wrote: > On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: >> On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov >> wrote: >>> On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov wrote: > On 02.08.2017 23:04, H.J.

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread H.J. Lu
On Thu, Aug 3, 2017 at 8:07 AM, Yury Gribov wrote: > On Thu, Aug 3, 2017 at 3:55 PM, H.J. Lu wrote: >> On Thu, Aug 3, 2017 at 7:17 AM, Yury Gribov >> wrote: >>> On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov wrote: > On Thu, Aug 3, 20

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 3:55 PM, H.J. Lu wrote: > On Thu, Aug 3, 2017 at 7:17 AM, Yury Gribov > wrote: >> On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: >>> On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov >>> wrote: On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: > On Wed, Aug 2, 2017 at

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread H.J. Lu
On Thu, Aug 3, 2017 at 7:17 AM, Yury Gribov wrote: > On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: >> On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov >> wrote: >>> On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov wrote: > On 02.08.2017 23:

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu wrote: > On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov > wrote: >> On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: >>> On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov >>> wrote: On 02.08.2017 23:04, H.J. Lu wrote: > > On Wed, Aug 2, 2017 at 1:56 P

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread H.J. Lu
On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov wrote: > On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: >> On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov >> wrote: >>> On 02.08.2017 23:04, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov wrote: > > On 02.08.2017 21:48

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu wrote: > On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov > wrote: >> On 02.08.2017 23:04, H.J. Lu wrote: >>> >>> On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov >>> wrote: On 02.08.2017 21:48, H.J. Lu wrote: > > > On Wed, Aug 2, 2017 at 1:39

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread H.J. Lu
On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov wrote: > On 02.08.2017 23:04, H.J. Lu wrote: >> >> On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov >> wrote: >>> >>> On 02.08.2017 21:48, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov wrote: > > > On 02.08.

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Yury Gribov
On 02.08.2017 23:04, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov wrote: On 02.08.2017 21:48, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov wrote: On 02.08.2017 20:02, Jeff Law wrote: On 08/02/2017 12:47 PM, Jakub Jelinek wrote: On Wed, Aug 02, 2017 at 12:3

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread H.J. Lu
On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov wrote: > On 02.08.2017 21:48, H.J. Lu wrote: >> >> On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov >> wrote: >>> >>> On 02.08.2017 20:02, Jeff Law wrote: On 08/02/2017 12:47 PM, Jakub Jelinek wrote: > > > On Wed, Aug 02, 2017 at 1

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Florian Weimer
* Jeff Law: > Something like setup a signal handler when we first start unwinding that > flags the error and tear it down when we're done unwinding?Obviously > we can't do setup/tear down each time for each address. Anyway, just > thinking outloud here... Linux doesn't have per-thread signal

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Yury Gribov
On 02.08.2017 21:48, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov wrote: On 02.08.2017 20:02, Jeff Law wrote: On 08/02/2017 12:47 PM, Jakub Jelinek wrote: On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: On 07/17/2017 01:23 AM, Yuri Gribov wrote: I've rebased the

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread H.J. Lu
On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov wrote: > On 02.08.2017 20:02, Jeff Law wrote: >> >> On 08/02/2017 12:47 PM, Jakub Jelinek wrote: >>> >>> On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: On 07/17/2017 01:23 AM, Yuri Gribov wrote: > > I've rebased the previous

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Yury Gribov
On 02.08.2017 20:02, Jeff Law wrote: On 08/02/2017 12:47 PM, Jakub Jelinek wrote: On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: On 07/17/2017 01:23 AM, Yuri Gribov wrote: I've rebased the previous patch to trunk per Andrew's suggestion. Original patch description/motivation/questio

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Jeff Law
On 08/02/2017 12:47 PM, Jakub Jelinek wrote: > On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: >> On 07/17/2017 01:23 AM, Yuri Gribov wrote: >>> I've rebased the previous patch to trunk per Andrew's suggestion. >>> Original patch description/motivation/questions are in >>> https://gcc.gnu

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Jakub Jelinek
On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: > On 07/17/2017 01:23 AM, Yuri Gribov wrote: > > I've rebased the previous patch to trunk per Andrew's suggestion. > > Original patch description/motivation/questions are in > > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01869.html > Is h

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Jeff Law
On 07/17/2017 01:23 AM, Yuri Gribov wrote: > Hi all, > > I've rebased the previous patch to trunk per Andrew's suggestion. > Original patch description/motivation/questions are in > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01869.html Is his stuff used for exception handling? If so, doesn't t

[RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-07-17 Thread Yuri Gribov
Hi all, I've rebased the previous patch to trunk per Andrew's suggestion. Original patch description/motivation/questions are in https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01869.html -Y safe-unwind-2.patch Description: Binary data #include #include struct _Unwind_Context; typedef int (*_