Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-23 Thread Richard Henderson
On 07/23/2011 05:12 AM, Paolo Bonzini wrote: > On Sat, Jul 23, 2011 at 02:32, Richard Henderson wrote: >> Does anyone object to me committing the patch as-is, with the >> understanding that either Paulo or myself will, before too long, >> clean up the DF interface as described above? > > I would

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-23 Thread Paolo Bonzini
On Sat, Jul 23, 2011 at 02:32, Richard Henderson wrote: > Does anyone object to me committing the patch as-is, with the > understanding that either Paulo or myself will, before too long, > clean up the DF interface as described above? I would kind of object for a pass that is enabled at some -O l

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-22 Thread Richard Henderson
On 07/22/2011 01:57 PM, Richard Henderson wrote: > On 07/22/2011 01:33 PM, Paolo Bonzini wrote: >> On Fri, Jul 22, 2011 at 02:09, Richard Henderson wrote: >>> I should mention here that I suspect the Cleanest solution is >>> to make DF_DEFER_INSN_RESCAN imply that we also shouldn't grab >>> data f

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-22 Thread Richard Henderson
On 07/22/2011 01:33 PM, Paolo Bonzini wrote: > On Fri, Jul 22, 2011 at 02:09, Richard Henderson wrote: >> I should mention here that I suspect the Cleanest solution is >> to make DF_DEFER_INSN_RESCAN imply that we also shouldn't grab >> data from the blocks those new insns are in either. In this

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-22 Thread Paolo Bonzini
On Fri, Jul 22, 2011 at 02:09, Richard Henderson wrote: > I should mention here that I suspect the Cleanest solution is > to make DF_DEFER_INSN_RESCAN imply that we also shouldn't grab > data from the blocks those new insns are in either.  In this > way one can create the block, link it up properl

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-21 Thread Richard Henderson
On 07/21/2011 03:11 PM, Richard Henderson wrote: > On 07/21/2011 03:05 PM, Steven Bosscher wrote: >> On Thu, Jul 21, 2011 at 11:17 PM, Richard Henderson wrote: >> >>> Suggestions for something better than the df_finish_pass hack >>> that I added at the end of partition_hot_cold_basic_blocks are >>

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-21 Thread Richard Henderson
On 07/21/2011 03:05 PM, Steven Bosscher wrote: > On Thu, Jul 21, 2011 at 11:17 PM, Richard Henderson wrote: > >> Suggestions for something better than the df_finish_pass hack >> that I added at the end of partition_hot_cold_basic_blocks are >> very welcome. > > Is it not enough to just call df_b

Re: [RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-21 Thread Steven Bosscher
On Thu, Jul 21, 2011 at 11:17 PM, Richard Henderson wrote: > Suggestions for something better than the df_finish_pass hack > that I added at the end of partition_hot_cold_basic_blocks are > very welcome. Is it not enough to just call df_bb_refs_record and df_analyze manually after you have creat

[RFC, cfg/dataflow] Properly split EH edges for -freorder-blocks-and-partition

2011-07-21 Thread Richard Henderson
Ignoring all of the other problems that partitioning might have, it does Just So Happen to work for the single most popular target. So let's see about keeping the pass limping along for a while longer. The problem I'm attempting to solve here is the gross hack in convert_to_eh_region_ranges, whic