Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-19 Thread Dominique d'Humières
Hi Andre, I have posted my results with your patch (and those for pr63851) at https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg02408.html. I don’t see any problem with unlimited_polymorphic_2.f90. However the character lengths are now wrong (they are 0) with your old patch for pr60289 at https

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-18 Thread Andre Vehreschild
Hi all, here is my next try on proposing a patch for the issue in pr60255. It took me quite some time to understand the intricacies with handling variables associated in a select type. I think I got most of the issues fixed now: - Added generation of _len component for each unlimited polymorphic

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-09 Thread Dominique d'Humières
Dear Andre, The patch causes an ICE for the test gfortran.dg/unlimited_polymorphic_1.f03: f951: internal compiler error: in gfc_add_component_ref, at fortran/class.c:236 f951: internal compiler error: Abort trap: 6 gfc: internal compiler error: Abort trap: 6 (program f951) Abort Reduced test fo

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-09 Thread Andre Vehreschild
Hi Paul, > s/furure/future/ :-) Hups, fixed. > Why are you using a double underscore in get__len_component? Because the component is called _len. The routine should be called "get _len component", but spaces aren't allowed :-) Anyways, does this violate some style guide? Should I remove one of

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-08 Thread Dominique d'Humières
Dear Paul, The problem for oo.f90 is pr 55901. I am updating my working tree with Andre’s patch. Cheers, Dominique > Le 8 déc. 2014 à 21:20, Paul Richard Thomas a > écrit : > > Dear Andre, > > s/furure/future/ :-) > > Why are you using a double underscore in get__len_component? > > More

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-08 Thread Andre Vehreschild
Hi all, please find attached a more elaborate patch for pr60255. I totally agree that my first attempt was just scratching the surface of the work needed. This patch also is *not* complete, but because I am really new to gfortran patching, I don't want to present a final patch only to learn then,