Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case

2012-11-28 Thread Diego Novillo
On Wed, Nov 28, 2012 at 6:02 PM, Doug Evans wrote: > On Wed, Nov 28, 2012 at 12:35 PM, Diego Novillo wrote: >> >> Am I right in understanding that you are intending to call >> >> $ validate_failures.py --clean_build=/path/to/gdb/bld >> --manifest=/path/to/gdb.sum ? >> >> If that's not what you ar

Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case

2012-11-28 Thread Doug Evans
On Wed, Nov 28, 2012 at 12:35 PM, Diego Novillo wrote: > On Wed, Nov 28, 2012 at 1:55 PM, Doug Evans wrote: > >> In gdb-land, parallel make check runs collect all the subdirectory >> .sum files and reconstruct testsuite/${tool}.sum. >> >> There's more than one solution of course: alternatively on

Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case

2012-11-28 Thread Diego Novillo
On Wed, Nov 28, 2012 at 1:55 PM, Doug Evans wrote: > In gdb-land, parallel make check runs collect all the subdirectory > .sum files and reconstruct testsuite/${tool}.sum. > > There's more than one solution of course: alternatively one could have > gdb stop doing this. But I'm not sure which is

Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case

2012-11-28 Thread Doug Evans
On Sun, Nov 25, 2012 at 7:40 AM, Diego Novillo wrote: > On Sat, Nov 24, 2012 at 5:47 PM, Doug Evans wrote: >> >> Hi. >> This third patch passes options.results to GetSumFiles when fetching the >> results >> for the clean build. >> It is useful in my use cases, but I'm not sure it's useful for ups

Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case

2012-11-25 Thread Diego Novillo
On Sat, Nov 24, 2012 at 5:47 PM, Doug Evans wrote: > > Hi. > This third patch passes options.results to GetSumFiles when fetching the > results > for the clean build. > It is useful in my use cases, but I'm not sure it's useful for upstream. > [An alternative is to add another option to specify th

[RFA 3/8] validate_failures.py: pass options.results for clean build case

2012-11-24 Thread Doug Evans
Hi. This third patch passes options.results to GetSumFiles when fetching the results for the clean build. It is useful in my use cases, but I'm not sure it's useful for upstream. [An alternative is to add another option to specify the results file(s) for the clean build, but I'm being conservative