Re: [RFA][PATCH] patch 5/n Cleaning up evrp

2017-11-17 Thread Jeff Law
On 11/17/2017 08:04 AM, Pedro Alves wrote: > On 11/17/2017 04:49 AM, Jeff Law wrote: > >> + /* We do not allow copying this object or initializing one from another. >> */ >> + evrp_dom_walker (const evrp_dom_walker &); >> + evrp_dom_walker& operator= (const evrp_dom_walker &); >> + > > Note

Re: [RFA][PATCH] patch 5/n Cleaning up evrp

2017-11-17 Thread Pedro Alves
On 11/17/2017 04:49 AM, Jeff Law wrote: > + /* We do not allow copying this object or initializing one from another. > */ > + evrp_dom_walker (const evrp_dom_walker &); > + evrp_dom_walker& operator= (const evrp_dom_walker &); > + Note you can use include/ansidecl.h's DISABLE_COPY_AND_ASSIGN

Re: [RFA][PATCH] patch 5/n Cleaning up evrp

2017-11-17 Thread Richard Biener
On Fri, Nov 17, 2017 at 5:49 AM, Jeff Law wrote: > So with the major reorganization bits in place it's time to start > cleaning up. > > This patch is primarily concerned with cleanups to the evrp_dom_walker > class. > > We pull a blob of code from execute_early_vrp into a new member > function. T

[RFA][PATCH] patch 5/n Cleaning up evrp

2017-11-16 Thread Jeff Law
So with the major reorganization bits in place it's time to start cleaning up. This patch is primarily concerned with cleanups to the evrp_dom_walker class. We pull a blob of code from execute_early_vrp into a new member function. That subsequently allows various data members to become private.