Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-06 Thread Jeff Law
On 11/06/2017 06:39 AM, Rainer Orth wrote: > Uros Bizjak writes: > >>> * config/i386/i386.c (ix86_emit_restore_reg_using_pop): >> Prototype. >>> (ix86_adjust_stack_and_probe_stack_clash): Use a push/pop >> sequence >>> to probe at the start of a noreturn functi

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-06 Thread Rainer Orth
Uros Bizjak writes: >> * config/i386/i386.c (ix86_emit_restore_reg_using_pop): > Prototype. >> (ix86_adjust_stack_and_probe_stack_clash): Use a push/pop > sequence >> to probe at the start of a noreturn function. >> >> * gcc.target/i386/stack-check-

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Uros Bizjak
3. nov. 2017 20:30 je oseba "Jeff Law" napisala: > > On 11/03/2017 11:38 AM, Uros Bizjak wrote: >> >> On Fri, Nov 3, 2017 at 6:13 PM, Jeff Law wrote: >>> >>> On 11/03/2017 04:46 AM, Uros Bizjak wrote: On Fri, Nov 3, 2017 at 11:14 AM, Richard Biener wrote: > > > On

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Jeff Law
On 11/03/2017 11:38 AM, Uros Bizjak wrote: On Fri, Nov 3, 2017 at 6:13 PM, Jeff Law wrote: On 11/03/2017 04:46 AM, Uros Bizjak wrote: On Fri, Nov 3, 2017 at 11:14 AM, Richard Biener wrote: On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: * config/i386/i386.c (ix86_emit_re

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Uros Bizjak
On Fri, Nov 3, 2017 at 6:13 PM, Jeff Law wrote: > On 11/03/2017 04:46 AM, Uros Bizjak wrote: >> >> On Fri, Nov 3, 2017 at 11:14 AM, Richard Biener >> wrote: >>> >>> On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: > > * config/i386/i386.c (ix86_emit_restore_reg_using_pop):

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Jeff Law
On 11/03/2017 04:46 AM, Uros Bizjak wrote: On Fri, Nov 3, 2017 at 11:14 AM, Richard Biener wrote: On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: * config/i386/i386.c (ix86_emit_restore_reg_using_pop): Prototype. (ix86_adjust_stack_and_probe_stack_clash): Use a push

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Jeff Law
On 11/03/2017 04:14 AM, Richard Biener wrote: On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: * config/i386/i386.c (ix86_emit_restore_reg_using_pop): Prototype. (ix86_adjust_stack_and_probe_stack_clash): Use a push/pop sequence to probe at the start of a n

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Jeff Law
On 11/03/2017 04:46 AM, Uros Bizjak wrote: On Fri, Nov 3, 2017 at 11:14 AM, Richard Biener wrote: On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: * config/i386/i386.c (ix86_emit_restore_reg_using_pop): Prototype. (ix86_adjust_stack_and_probe_stack_clash): Use a push

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Jeff Law
On 11/03/2017 02:38 AM, Uros Bizjak wrote: * config/i386/i386.c (ix86_emit_restore_reg_using_pop): Prototype. (ix86_adjust_stack_and_probe_stack_clash): Use a push/pop sequence to probe at the start of a noreturn function. * gcc.target/i386/stack-c

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Uros Bizjak
On Fri, Nov 3, 2017 at 11:14 AM, Richard Biener wrote: > On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: >>>* config/i386/i386.c (ix86_emit_restore_reg_using_pop): >>> Prototype. >>>(ix86_adjust_stack_and_probe_stack_clash): Use a push/pop >>> sequence >>>

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Richard Biener
On Fri, Nov 3, 2017 at 9:38 AM, Uros Bizjak wrote: >>* config/i386/i386.c (ix86_emit_restore_reg_using_pop): Prototype. >>(ix86_adjust_stack_and_probe_stack_clash): Use a push/pop sequence >>to probe at the start of a noreturn function. >> >>* gcc.ta

Re: [RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-03 Thread Uros Bizjak
>* config/i386/i386.c (ix86_emit_restore_reg_using_pop): Prototype. >(ix86_adjust_stack_and_probe_stack_clash): Use a push/pop sequence >to probe at the start of a noreturn function. > >* gcc.target/i386/stack-check-12.c: New test - emit_stack_p

[RFA][PATCH] Improve initial probe for noreturn functions for x86 target

2017-11-02 Thread Jeff Law
The x86 port relies on implicit probes that occur when a call instruction pushes the return address onto the stack. Those implicit calls allow the target to avoid emitting explicit stack probes. Of course we have to account for tail call optimizations which turn the call into a jump -- in p