Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-29 Thread Jakub Jelinek
On Tue, Nov 29, 2016 at 08:27:04PM +0800, Chung-Lin Tang wrote: > On 2016/11/18 7:23 PM, Jakub Jelinek wrote: > > On Thu, Nov 17, 2016 at 05:34:34PM +0800, Chung-Lin Tang wrote: > >> Updated C/C++ front-end patches, adjusted as reviewed. > > > > Jason is right, finish_omp_clauses will verify the t

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-29 Thread Chung-Lin Tang
On 2016/11/18 7:23 PM, Jakub Jelinek wrote: > On Thu, Nov 17, 2016 at 05:34:34PM +0800, Chung-Lin Tang wrote: >> Updated C/C++ front-end patches, adjusted as reviewed. > > Jason is right, finish_omp_clauses will verify the tile operands > when !processing_template_decl are non-negative host INTEGE

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-18 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 05:34:34PM +0800, Chung-Lin Tang wrote: > Updated C/C++ front-end patches, adjusted as reviewed. Jason is right, finish_omp_clauses will verify the tile operands when !processing_template_decl are non-negative host INTEGER_CSTs, so can't you just tsubst it like OMP_CLAUSE_C

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-17 Thread Jason Merrill
On 11/17/2016 04:34 AM, Chung-Lin Tang wrote: + /* These clauses really need a positive integral constant expression, +but we don't have a predicate for that (yet). */ What do you mean? Don't you check this in finish_omp_clauses after the tsubst? Jason

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 6:30 PM, Jakub Jelinek wrote: > On Thu, Nov 10, 2016 at 06:46:16PM +0800, Chung-Lin Tang wrote: >> 2016-XX-XX Nathan Sidwell >> >> c/ >> * c-parser.c (c_parser_omp_clause_collapse): Disallow tile. >> (c_parser_oacc_clause_tile): Disallow collapse. Fix parsin

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-11 Thread Jakub Jelinek
On Thu, Nov 10, 2016 at 06:46:16PM +0800, Chung-Lin Tang wrote: > 2016-XX-XX Nathan Sidwell > > c/ > * c-parser.c (c_parser_omp_clause_collapse): Disallow tile. > (c_parser_oacc_clause_tile): Disallow collapse. Fix parsing and > semantic checking. > * c-p

[Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-10 Thread Chung-Lin Tang
These are the patches for the C/C++ front-ends, along with the testsuite patches. Thanks, Chung-Lin 2016-XX-XX Nathan Sidwell c/ * c-parser.c (c_parser_omp_clause_collapse): Disallow tile. (c_parser_oacc_clause_tile): Disallow collapse. Fix parsing and semantic