> Fixed.
>
> It's not fully tested. I just run the 28_regex testcases. I'll do a
> full test before committing.
Committed.
--
Tim Shen
changelog
Description: Binary data
regex-locale.patch
Description: Binary data
On Sat, Aug 24, 2013 at 1:51 AM, Stefan Schweter wrote:
> Am Fri, 23 Aug 2013 17:17:41 +0800
> schrieb Tim Shen :
>
>> Inspired by this mail:
>> http://gcc.gnu.org/ml/libstdc++/2013-08/msg00131.html
>>
>> Thanks!
>>
>>
>
> Hi Tim,
>
> I applied the patch + compiled everything - it's working now! T
Am Fri, 23 Aug 2013 17:17:41 +0800
schrieb Tim Shen :
> Inspired by this mail:
> http://gcc.gnu.org/ml/libstdc++/2013-08/msg00131.html
>
> Thanks!
>
>
Hi Tim,
I applied the patch + compiled everything - it's working now! Thanks!
But... I found a problem with .imbue():
int main()
{
s
On 23 August 2013 16:48, Tim Shen wrote:
> By the way, do we seariously need to keep ChangeLog in files? Is it
> more like a tradition than a solution? After all, we have SVN or Git
> now. I remember a mail metioned this but cannot find it >.<
It's not a tradition, they are required, see
http://ww
On Fri, Aug 23, 2013 at 11:03 PM, Paolo Carlini
wrote:
> The assign change is fine. But I would also put between round brackets
> (class _Compiler<>) for the _M_traits change and use something like
> (_DFSExecutor<>::_DFSExecutor): Adjust. for the last change (remember that
> constructors are spec
On 08/23/2013 04:53 PM, Tim Shen wrote:
On Fri, Aug 23, 2013 at 10:26 PM, Paolo Carlini
wrote:
Great. But please but the names of the functions you are changing between
round brackets. You have tons of examples everywhere.
...like this?
The assign change is fine. But I would also put between r
On 23 August 2013 15:53, Tim Shen wrote:
> On Fri, Aug 23, 2013 at 10:26 PM, Paolo Carlini
> wrote:
>> Great. But please but the names of the functions you are changing between
>> round brackets. You have tons of examples everywhere.
>
> ...like this?
Yes, that makes it clear what part of the fil
On Fri, Aug 23, 2013 at 10:26 PM, Paolo Carlini
wrote:
> Great. But please but the names of the functions you are changing between
> round brackets. You have tons of examples everywhere.
...like this?
--
Tim Shen
changelog
Description: Binary data
On 08/23/2013 03:59 PM, Tim Shen wrote:
On Fri, Aug 23, 2013 at 6:29 PM, Paolo Carlini wrote:
Thanks a lot indeed. But: "Fix callers" of *what*?!? And from *where*? To be
really honest this kind of ChangeLog entry doesn't make much sense. Please
get used to list the specific functions you are c
On Fri, Aug 23, 2013 at 6:29 PM, Paolo Carlini wrote:
> Thanks a lot indeed. But: "Fix callers" of *what*?!? And from *where*? To be
> really honest this kind of ChangeLog entry doesn't make much sense. Please
> get used to list the specific functions you are changing. It's important.
I see.
Act
Hi,
On 08/23/2013 11:17 AM, Tim Shen wrote:
2013-08-23 Tim Shen
* include/bits/regex.h: Fix callers.
* include/bits/regex_compiler.h: Store _Traits reference.
* include/bits/regex_executor.h: Add _Traits member for _DFSExecutor.
* include/bits/regex_exe
On 23 August 2013 10:17, Tim Shen wrote:
> Inspired by this mail: http://gcc.gnu.org/ml/libstdc++/2013-08/msg00131.html
This is OK too, thanks for the quick fix to the locale issue!
Inspired by this mail: http://gcc.gnu.org/ml/libstdc++/2013-08/msg00131.html
Thanks!
--
Tim Shen
regex-locale.patch
Description: Binary data
13 matches
Mail list logo
