Re: [EXTERNAL] Re: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-18 Thread Segher Boessenkool
On Thu, Aug 13, 2020 at 06:53:56PM -0500, will schmidt wrote: > On Thu, 2020-08-13 at 17:55 -0500, Segher Boessenkool wrote: > > > As long as there are no issues defining the builtins for 3.0 here. > > > AFAIK they are not documented in ISA 3.0. This is a happy accident > > > that these ISA 3.1 bu

Re: [EXTERNAL] Re: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-13 Thread will schmidt via Gcc-patches
On Thu, 2020-08-13 at 17:55 -0500, Segher Boessenkool wrote: > Hi! > > On Thu, Aug 13, 2020 at 05:11:11PM -0500, will schmidt wrote: > > > > That is probably a level of detail that is not > > > > really needed in the GCC code comment. Probably best to just > > > > change > > > > the comment to re

Re: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-13 Thread Segher Boessenkool
Hi! On Thu, Aug 13, 2020 at 05:11:11PM -0500, will schmidt wrote: > > > That is probably a level of detail that is not > > > really needed in the GCC code comment. Probably best to just > > > change > > > the comment to read something like "ISA 3.0 sign extend builtins". > > > > Sounds good. >

Re: [EXTERNAL] Re: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-13 Thread will schmidt via Gcc-patches
On Thu, 2020-08-13 at 13:29 -0500, Segher Boessenkool wrote: > On Thu, Aug 13, 2020 at 11:09:10AM -0700, Carl Love wrote: > > The builtins > > > > vector signed int vec_signexti (vector signed char a) > > vector signed long long vec_signextll (vector signed char a) > > vector signed int vec_signex

Re: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-13 Thread Segher Boessenkool
On Thu, Aug 13, 2020 at 11:09:10AM -0700, Carl Love wrote: > The builtins > > vector signed int vec_signexti (vector signed char a) > vector signed long long vec_signextll (vector signed char a) > vector signed int vec_signexti (vector signed short a) > vector signed long long vec_signextll (vecto

RE: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-13 Thread Carl Love via Gcc-patches
Segher: On Thu, 2020-08-13 at 12:36 -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Aug 11, 2020 at 12:22:37PM -0700, Carl Love wrote: > > +/* Sign extend builtins that work on ISA 3.0, but not defined > > until ISA 3.1. */ > > What does this mean? Not defined in GCC before now? Does it ne

Re: [Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-13 Thread Segher Boessenkool
Hi! On Tue, Aug 11, 2020 at 12:22:37PM -0700, Carl Love wrote: > +/* Sign extend builtins that work on ISA 3.0, but not defined until ISA 3.1. > */ What does this mean? Not defined in GCC before now? Does it need backporting? Not defined in older versions of the ELFv2 ABI (or vector doc) and

[Patch 1/5] rs6000, Add 128-bit sign extension support

2020-08-11 Thread Carl Love via Gcc-patches
Segher, Will: Patch 1, adds the sign extension instruction support and corresponding builtins. Carl Love - RS6000 Add 128-bit sign extension support gcc/ChangeLog 2020-08-10 Carl Love * config/rs6000/al