On Fri, Aug 30, 2013 at 10:04 PM, Tim Shen wrote:
> I didn't use any tool to check that, but adjust it by hand. It
> shouldn't break anything, but I'll test it again before committing.
Tested under -m32, -m64 and debug mode and committed.
--
Tim Shen
Hi,
> wrote:
>> Other than the test case (breaks on mingw32 target) this is looking
>very sweet.
>
>Could you please show some details?
I suppose he referred to the char/wchar_t split which I described...
Thanks!
Paolo
On Fri, Aug 30, 2013 at 9:26 AM, Paolo Carlini wrote:
> Hi,
>
> On 08/30/2013 02:05 PM, Tim Shen wrote:
>>
>> + const _TraitsT&_M_traits;
>> + _FlagT _M_flags;
>> + bool _M_is_non_matching;
>> + std::
On Fri, 2013-08-30 15:36:03 +0200, Jakub Jelinek wrote:
> On Fri, Aug 30, 2013 at 03:26:59PM +0200, Paolo Carlini wrote:
> > On 08/30/2013 02:05 PM, Tim Shen wrote:
> > >+ const _TraitsT&_M_traits;
> > >+ _FlagT _M_flags;
> > >+ bool
On Fri, Aug 30, 2013 at 03:26:59PM +0200, Paolo Carlini wrote:
> Hi,
>
> On 08/30/2013 02:05 PM, Tim Shen wrote:
> >+ const _TraitsT&_M_traits;
> >+ _FlagT _M_flags;
> >+ bool _M_is_non_matching;
> >+
Hi,
On 08/30/2013 02:05 PM, Tim Shen wrote:
+ const _TraitsT&_M_traits;
+ _FlagT _M_flags;
+ bool _M_is_non_matching;
+ std::set<_CharT> _M_char_set;
+ std::set> _M_range_set;
.. the testcase is not Ok. We want separate tests for char and wchar_t,
in separate subdirs with the names 'char' and 'wchar_t'. In this way,
the framework automatically helps us and doesn't try to run the latter
for targets which don't have wchar_t.
Eg, testsuite/21_strings is completely stru
Rewrite matchers using structs instead of closures. It's more clear
and easy to maintain now.
Tested under -m32, -m64 and debug mode.
Thanks!
--
Tim Shen
matchers.patch
Description: Binary data
