Re: [Patch] Fix objc/48109

2011-06-30 Thread Iain Sandoe
Hi Richard(s), thanks for the reviews. before re-jigging - a couple of questions / points below. On 30 Jun 2011, at 16:12, Richard Henderson wrote: On 06/30/2011 03:56 AM, Richard Guenther wrote: It is only used by darwin at present - so nothing is split out for any other target (the defau

Re: [Patch] Fix objc/48109

2011-06-30 Thread Richard Henderson
On 06/30/2011 03:56 AM, Richard Guenther wrote: >> > It is only used by darwin at present - so nothing is split out for any >> > other >> > target (the default hook is simply 'false'). > Yes, I've seen that. Still a hook like this should be generally useful, > and you still process through some p

Re: [Patch] Fix objc/48109

2011-06-30 Thread Richard Guenther
On Thu, Jun 30, 2011 at 12:50 PM, Iain Sandoe wrote: > > On 30 Jun 2011, at 11:27, Richard Guenther wrote: > >> On Wed, Jun 29, 2011 at 7:47 PM, Iain Sandoe >> wrote: >>> >>> The bug arises because of the use, by the ObjC FE, of two old target >>> macros >>> that emit efficient representations of

Re: [Patch] Fix objc/48109

2011-06-30 Thread Iain Sandoe
On 30 Jun 2011, at 11:27, Richard Guenther wrote: On Wed, Jun 29, 2011 at 7:47 PM, Iain Sandoe wrote: The bug arises because of the use, by the ObjC FE, of two old target macros that emit efficient representations of class definitions and references. This 'works fine' (however wrong it m

Re: [Patch] Fix objc/48109

2011-06-30 Thread Richard Guenther
On Wed, Jun 29, 2011 at 7:47 PM, Iain Sandoe wrote: > The bug arises because of the use, by the ObjC FE, of two old target macros > that emit efficient representations of class definitions and references. > > This 'works fine' (however wrong it might be conceptually), until LTO is > engaged, where

Re: [Patch] Fix objc/48109

2011-06-29 Thread Mike Stump
On Jun 29, 2011, at 10:47 AM, Iain Sandoe wrote: > The bug arises because of the use, by the ObjC FE, of two old target macros > that emit efficient representations of class definitions and references. > Mike has already given this a 'seems reasonable' in the PR thread, however, I > need an appr

[Patch] Fix objc/48109

2011-06-29 Thread Iain Sandoe
The bug arises because of the use, by the ObjC FE, of two old target macros that emit efficient representations of class definitions and references. This 'works fine' (however wrong it might be conceptually), until LTO is engaged, whereupon the definitions vanish without trace (since no c