Re: Ping #1: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-02-01 Thread Georg-Johann Lay
Jakub Jelinek wrote: > On Wed, Feb 01, 2012 at 02:00:53PM +0100, Georg-Johann Lay wrote: >>> * gcc.dg/lto/20091013-1_1.c: xfail for avr. >>> * gcc.dg/lto/20091013-1_2.c: xfail for avr. > > If it is just because of the warnings, can't you > add > -Wno-int-to-pointer-cast -Wno-pointer-to-int

Re: Ping #1: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-02-01 Thread Jakub Jelinek
On Wed, Feb 01, 2012 at 02:00:53PM +0100, Georg-Johann Lay wrote: > > * gcc.dg/lto/20091013-1_1.c: xfail for avr. > > * gcc.dg/lto/20091013-1_2.c: xfail for avr. If it is just because of the warnings, can't you add -Wno-int-to-pointer-cast -Wno-pointer-to-int-cast to dg-options? Also, not

Ping #1: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-02-01 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01502.html Georg-Johann Lay wrote: > Jakub Jelinek wrote: >> On Fri, Jan 13, 2012 at 07:40:59PM +0100, Georg-Johann Lay wrote: >>> The ilp32 is the closes match: >>> >>> The source casts pointer to int, int to pointer, long to int, uses 32-bit >>> init

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-27 Thread Georg-Johann Lay
Jakub Jelinek wrote: > On Fri, Jan 13, 2012 at 07:40:59PM +0100, Georg-Johann Lay wrote: >> The ilp32 is the closes match: >> >> The source casts pointer to int, int to pointer, long to int, uses 32-bit >> initializers for int, assumes size_t is unsigned long any maybe others. > > No. The source

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-16 Thread Pedro Alves
On 01/13/2012 08:21 PM, Georg-Johann Lay wrote: > I really don't expect anyone to run test suites on any platform or target > supported by GCC. Such an approach is completely useless because of the amount > of time and system resources and I never proposed that. > > But it appears that many of th

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-15 Thread Georg-Johann Lay
Rainer Orth schrieb: Mike Stump writes: On Jan 13, 2012, at 4:33 AM, Georg-Johann Lay wrote: This test case is obviously written for 32-bit platforms, thus added "dg-require-effective-target ilp32" to ensure that the pointer mess won't lead to FAILs because of warning: cast to pointer from

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Mike Stump
On Jan 13, 2012, at 11:25 AM, Georg-Johann Lay wrote: > So it's fine to dump any code to the test suite no matter on what platform it > might break or work? No. It isn't fine, but it does happen. Some people spend a lot of time, trying to get the testcases minimal, portable and correct. Other

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Georg-Johann Lay
Jakub Jelinek wrote: > On Fri, Jan 13, 2012 at 08:25:39PM +0100, Georg-Johann Lay wrote: >> So it's fine to dump any code to the test suite no matter on what platform it >> might break or work? > > It is wrong to knowingly commit testcases that break on such platforms, > but you really shouldn't e

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Jakub Jelinek
On Fri, Jan 13, 2012 at 08:25:39PM +0100, Georg-Johann Lay wrote: > So it's fine to dump any code to the test suite no matter on what platform it > might break or work? It is wrong to knowingly commit testcases that break on such platforms, but you really shouldn't expect every committer to test a

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Georg-Johann Lay
Jakub Jelinek wrote: > On Fri, Jan 13, 2012 at 07:40:59PM +0100, Georg-Johann Lay wrote: >> The ilp32 is the closes match: >> >> The source casts pointer to int, int to pointer, long to int, uses 32-bit >> initializers for int, assumes size_t is unsigned long any maybe others. > > No. The source

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Jakub Jelinek
On Fri, Jan 13, 2012 at 07:40:59PM +0100, Georg-Johann Lay wrote: > The ilp32 is the closes match: > > The source casts pointer to int, int to pointer, long to int, uses 32-bit > initializers for int, assumes size_t is unsigned long any maybe others. No. The source is just fine for any target wh

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Georg-Johann Lay
Mike Stump wrote: > On Jan 13, 2012, at 9:23 AM, Rainer Orth wrote: >> Mike Stump writes: >> >>> On Jan 13, 2012, at 4:33 AM, Georg-Johann Lay wrote: This test case is obviously written for 32-bit platforms, thus added "dg-require-effective-target ilp32" to ensure that the pointer mess w

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Mike Stump
On Jan 13, 2012, at 9:23 AM, Rainer Orth wrote: > Mike Stump writes: > >> On Jan 13, 2012, at 4:33 AM, Georg-Johann Lay wrote: >>> This test case is obviously written for 32-bit platforms, thus added >>> "dg-require-effective-target ilp32" to ensure that the pointer mess won't >>> lead >>> to FA

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Rainer Orth
Mike Stump writes: > On Jan 13, 2012, at 4:33 AM, Georg-Johann Lay wrote: >> This test case is obviously written for 32-bit platforms, thus added >> "dg-require-effective-target ilp32" to ensure that the pointer mess won't >> lead >> to FAILs because of >> >> warning: cast to pointer from integ

Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Mike Stump
On Jan 13, 2012, at 4:33 AM, Georg-Johann Lay wrote: > This test case is obviously written for 32-bit platforms, thus added > "dg-require-effective-target ilp32" to ensure that the pointer mess won't lead > to FAILs because of > > warning: cast to pointer from integer of different size > > and >

[Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-01-13 Thread Georg-Johann Lay
This test case is obviously written for 32-bit platforms, thus added "dg-require-effective-target ilp32" to ensure that the pointer mess won't lead to FAILs because of warning: cast to pointer from integer of different size and warning: cast from pointer to integer of different size Ok to apply