[Patch] gcn/mkoffload.cc: Re-add fprintf for #include of stdlib.h/stdbool.h (was: [Patch, v3] gcn/mkoffload.cc: Use #embed for including the generated ELF file)

2024-09-20 Thread Tobias Burnus
Hi Thomas, See attached patch for adding the include lines: + if (gcn_stack_size) +{ + fprintf (cfile, "#include \n"); + fprintf (cfile, "#include \n\n"); but contrary to previously there is no 'stdint.h' and they are also not unconditionally included. (The 'stdbool.h' is only u

Re: [Patch, v3] gcn/mkoffload.cc: Use #embed for including the generated ELF file

2024-09-20 Thread Thomas Schwinge
Hi Tobias! I've not verified, but I very much suspect that this change: On 2024-09-13T16:24:47+0200, Tobias Burnus wrote: > commit 508ef585243d4674d06b0737bfe8769fc18f824f > Author: Tobias Burnus > Date: Fri Sep 13 16:18:46 2024 +0200 > > gcn/mkoffload.cc: Use #embed for including the gen

Re: [Patch, v3] gcn/mkoffload.cc: Use #embed for including the generated ELF file

2024-09-13 Thread Jakub Jelinek
On Fri, Sep 13, 2024 at 04:24:47PM +0200, Tobias Burnus wrote: > As #embed is now supported by GCC (thanks!), I could commit this patch :-) Thanks to Joseph for the reviews. > Committed as r15-3629-g508ef585243d46 → > https://gcc.gnu.org/r15-3629-g508ef585243d46 > > Unless I missed something, we

Re: [Patch, v3] gcn/mkoffload.cc: Use #embed for including the generated ELF file

2024-09-13 Thread Tobias Burnus
On July 19, 2024 Tobias Burnus wrote: Updated patch attached. As #embed is now supported by GCC (thanks!), I could commit this patch :-) Committed as r15-3629-g508ef585243d46 → https://gcc.gnu.org/r15-3629-g508ef585243d46 Unless I missed something, we need to wait for a few pending patches

[Patch, v3] gcn/mkoffload.cc: Use #embed for including the generated ELF file

2024-07-19 Thread Tobias Burnus
Hi, Jakub Jelinek wrote: + "#if defined(__STDC_EMBED_FOUND__) && __has_embed (\"%s\") == __STDC_EMBED_FOUND__\n" If this was an attempt to deal gracefully with no #embed support, then the above would be wrong and should have been #if defined(__STDC_EMBED_FOUND__) && defined(__has_embe