Re: [Patch, regex, libstdc++/69794] Unify special character parsing

2016-02-16 Thread Jonathan Wakely
On 15/02/16 20:41 -0800, Tim Shen wrote: PR libstdc++/69794 * include/bits/regex_scanner.h: Add different special character sets for grep and egrep regex. * include/bits/regex_scanner.tcc: Use _M_spec_char more unifiedly. s/unifiedly/uniformly/ OK for trunk and

Re: [Patch, regex, libstdc++/69794] Unify special character parsing

2016-02-15 Thread Tim Shen
On Mon, Feb 15, 2016 at 4:26 AM, Jonathan Wakely wrote: > Those new members change the size of the type, so are an ABI change. > > Couldn't they be static members? Ahh right. Since they are just used for once, use them in the line. -- Regards, Tim Shen commit 4db39da3091a33e4125ffd8b55da378592

Re: [Patch, regex, libstdc++/69794] Unify special character parsing

2016-02-15 Thread Jonathan Wakely
On 13/02/16 11:13 -0800, Tim Shen wrote: I did it wrong in r227289 - I ignored the "\n" special case in grep. Turns out using code to handle special cases is error prone, so I turned to use data (_M_grep_spec_char and _M_egrep_spec_char). Those new members change the size of the type, so are an

[Patch, regex, libstdc++/69794] Unify special character parsing

2016-02-13 Thread Tim Shen
I did it wrong in r227289 - I ignored the "\n" special case in grep. Turns out using code to handle special cases is error prone, so I turned to use data (_M_grep_spec_char and _M_egrep_spec_char). Bootstrapped and tested on x86_64-pc-linux-gnu. Thanks! -- Regards, Tim Shen commit 03e651ef56e51