On Wed, Sep 16, 2015 at 10:38 AM, Jonathan Wakely wrote:
> On 12/09/15 01:57 +, Tim Shen wrote:
>>
>> Ok then, let's not appending dynamic location string, but only throw a
>> string literal pointer.
>
>
> This looks great, and a *huge* improvement on the current errors even
> without more pre
On 12/09/15 01:57 +, Tim Shen wrote:
Ok then, let's not appending dynamic location string, but only throw a
string literal pointer.
This looks great, and a *huge* improvement on the current errors even
without more precise location info.
OK for trunk, thanks very much for doing this.
On Mon, Sep 7, 2015 at 4:06 AM, Jonathan Wakely wrote:
> On 28/08/15 11:23 -0700, Tim Shen wrote:
>>
>> On Fri, Aug 28, 2015 at 8:59 AM, Jonathan Wakely
>> wrote:
>>>
>>> There seems to be no need to construct a std::string here, just pass a
>>> const char* (see below).
>>
>>
>> To be honest, I w
On 28/08/15 11:23 -0700, Tim Shen wrote:
On Fri, Aug 28, 2015 at 8:59 AM, Jonathan Wakely wrote:
There seems to be no need to construct a std::string here, just pass a
const char* (see below).
To be honest, I wasn't considering performance for a bit, since
exceptions are already considered sl
On 28/08/15 20:44 -0700, Tim Shen wrote:
On Fri, Aug 28, 2015 at 11:23 AM, Tim Shen wrote:
So is it good to have an owned raw pointer stored in runtime_error,
pointing to a heap allocated char chunk, which will be deallocated in
regex_error's dtor?
I just put a string member into regex_error,
On Fri, Aug 28, 2015 at 11:23 AM, Tim Shen wrote:
> So is it good to have an owned raw pointer stored in runtime_error,
> pointing to a heap allocated char chunk, which will be deallocated in
> regex_error's dtor?
I just put a string member into regex_error, completely ignoring the
storage in std
On Fri, Aug 28, 2015 at 8:59 AM, Jonathan Wakely wrote:
> There seems to be no need to construct a std::string here, just pass a
> const char* (see below).
To be honest, I wasn't considering performance for a bit, since
exceptions are already considered slow by me :P. But yes, we can do
less allo
On 27/08/15 22:18 -0700, Tim Shen wrote:
Bootstrapped and tested.
Thanks!
--
Regards,
Tim Shen
commit 53c1caff442e97a18652ec8b1d984341168fd98d
Author: Tim Shen
Date: Thu Aug 27 21:42:40 2015 -0700
PR libstdc++/67361
* include/bits/regex_error.h: Add __throw_regex_error t
Bootstrapped and tested.
Thanks!
--
Regards,
Tim Shen
commit 53c1caff442e97a18652ec8b1d984341168fd98d
Author: Tim Shen
Date: Thu Aug 27 21:42:40 2015 -0700
PR libstdc++/67361
* include/bits/regex_error.h: Add __throw_regex_error that
supports string.
* includ
