Re: [Patch, libfortran] PR 52434/48878/38199 Improve floating point formatted writes

2012-03-15 Thread Jerry DeLisle
On 03/15/2012 02:55 AM, Janne Blomqvist wrote: On Thu, Mar 15, 2012 at 01:52, Jerry DeLisle wrote: I like the idea behind this patch. I confess, I have not studied the two test cases that you are modifying, but the changes seem to stick out with too many digits there. Is this really correct?

Re: [Patch, libfortran] PR 52434/48878/38199 Improve floating point formatted writes

2012-03-14 Thread Janne Blomqvist
On Thu, Mar 15, 2012 at 01:52, Jerry DeLisle wrote: > I like the idea behind this patch.  I confess, I have not studied the two > test cases that you are modifying, but the changes seem to stick out with > too many digits there.  Is this really correct? > When I get another moment, I will look clo

Re: [Patch, libfortran] PR 52434/48878/38199 Improve floating point formatted writes

2012-03-14 Thread Jerry DeLisle
On 03/08/2012 05:40 PM, Janne Blomqvist wrote: Hi, the attached patch implements some improvements for formatted writes of floating point values. Currently libgfortran uses snprintf() to fill a buffer with a fixed amount of digits, regardless of the digits required, and then rounding or zero ext

Re: [Patch, libfortran] PR 52434/48878/38199 Improve floating point formatted writes

2012-03-09 Thread Janne Blomqvist
On Fri, Mar 9, 2012 at 00:40, Janne Blomqvist wrote: > Note that GFortran previously did roundTiesToAway, whereas at least > glibc snprintf() does roundTiesToEven, so some change in behavior is > expected. Anyway, this is IMHO for the better, as it avoids biasing > the magnitude upwards in some co

[Patch, libfortran] PR 52434/48878/38199 Improve floating point formatted writes

2012-03-08 Thread Janne Blomqvist
Hi, the attached patch implements some improvements for formatted writes of floating point values. Currently libgfortran uses snprintf() to fill a buffer with a fixed amount of digits, regardless of the digits required, and then rounding or zero extending as needed. The patch changes this to first