Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-02-02 Thread Janne Blomqvist
On Tue, Jan 31, 2012 at 02:46, Gerald Pfeifer wrote: > On Sun, 29 Jan 2012, Janne Blomqvist wrote: >>> .../gcc-HEAD/gcc/fortran/decl.c:5820:23: error: invalid conversion from >>> 'const char*' to 'char*' [-fpermissive] >>> gmake[3]: *** [fortran/decl.o] Error 1 >> Have you tried r183679, which sh

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-30 Thread Gerald Pfeifer
On Sun, 29 Jan 2012, Janne Blomqvist wrote: >> .../gcc-HEAD/gcc/fortran/decl.c:5820:23: error: invalid conversion from >> 'const char*' to 'char*' [-fpermissive] >> gmake[3]: *** [fortran/decl.o] Error 1 > Have you tried r183679, which should fix this? Yes, I now tried that update (my daily teste

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-29 Thread Tobias Burnus
Janne Blomqvist wrote: Have you tried r183679, which should fix this? Aha, I missed the follow up patch - that explains why I didn't see it. While I can speak only for myself, regtesting on x86_64-unknown-linux-gnu. For some reason this was/is flagged as a warning for me, not an error, so I

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-29 Thread Tobias Burnus
Gerald Pfeifer wrote: On Sun, 29 Jan 2012, Janne Blomqvist wrote: Taking into account the suggestions by Tobias and Mikael, attached is the patch I just committed. Thanks for the reviews! I am now seeing the following bootstrap error on all my FreeBSD testers, and this does not appear to be ope

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-29 Thread Janne Blomqvist
On Sun, Jan 29, 2012 at 23:36, Gerald Pfeifer wrote: > On Sun, 29 Jan 2012, Janne Blomqvist wrote: >> Taking into account the suggestions by Tobias and Mikael, attached is >> the patch I just committed. Thanks for the reviews! > > I am now seeing the following bootstrap error on all my FreeBSD tes

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-29 Thread Gerald Pfeifer
On Sun, 29 Jan 2012, Janne Blomqvist wrote: > Taking into account the suggestions by Tobias and Mikael, attached is > the patch I just committed. Thanks for the reviews! I am now seeing the following bootstrap error on all my FreeBSD testers, and this does not appear to be operating system-specif

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-29 Thread Janne Blomqvist
On Wed, Jan 18, 2012 at 14:45, Mikael Morin wrote: > On 18.01.2012 10:12, Tobias Burnus wrote: >> >> >> Dear Janne, >> >>> the attached patch changes the binding labels that are needed for >>> bind(C) symbols to be heap allocated rather than, as currently, being >>> fixed size arrays of size 127 (

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-18 Thread Mikael Morin
On 18.01.2012 10:12, Tobias Burnus wrote: Dear Janne, the attached patch changes the binding labels that are needed for bind(C) symbols to be heap allocated rather than, as currently, being fixed size arrays of size 127 (or 64 in module.c!?). wonder whether it would have been smarter to us

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-18 Thread Tobias Burnus
Dear Janne, > the attached patch changes the binding labels that are needed for > bind(C) symbols to be heap allocated rather than, as currently, being > fixed size arrays of size 127 (or 64 in module.c!?). wonder whether it would have been smarter to use string matching rather than the manual m

[Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-13 Thread Janne Blomqvist
Hi, the attached patch changes the binding labels that are needed for bind(C) symbols to be heap allocated rather than, as currently, being fixed size arrays of size 127 (or 64 in module.c!?). There are two benefits of this: 1) For the vast majority of symbols which are not bind(C) symbols in a t