Re: [Patch, Fortran] PR56845 - Fix setting of vptr of CLASS(...),SAVE,ALLOCATABLE

2013-04-12 Thread Tobias Burnus
Am 12.04.2013 08:41, schrieb Janus Weil: 2013/4/12 Tobias Burnus : I think there was a test-suite failure when I tried it. In any case, variables might be in static memory even if attr.save is not set: - Module variables - Variables of the main program - Local variables of constant size (instea

Re: [Patch, Fortran] PR56845 - Fix setting of vptr of CLASS(...),SAVE,ALLOCATABLE

2013-04-11 Thread Janus Weil
2013/4/12 Tobias Burnus : > Am 12.04.2013 00:05, schrieb Janus Weil: > >> Just one minor nit: >> >> + if (sym->ts.type == BT_CLASS && TREE_STATIC (sym->backend_decl) >> + && CLASS_DATA (sym)->attr.allocatable) >> >> I'd find it somewhat clearer to check for "sym->attr.save" instead of >>

Re: [Patch, Fortran] PR56845 - Fix setting of vptr of CLASS(...),SAVE,ALLOCATABLE

2013-04-11 Thread Tobias Burnus
Am 12.04.2013 00:05, schrieb Janus Weil: Just one minor nit: + if (sym->ts.type == BT_CLASS && TREE_STATIC (sym->backend_decl) + && CLASS_DATA (sym)->attr.allocatable) I'd find it somewhat clearer to check for "sym->attr.save" instead of "TREE_STATIC (sym->backend_decl)", but that may

Re: [Patch, Fortran] PR56845 - Fix setting of vptr of CLASS(...),SAVE,ALLOCATABLE

2013-04-11 Thread Janus Weil
Hi Tobias, > An unallocated polymorphic variable has the declared type; however, for > static (SAVE) variables, the current code didn't set the value. > > (That the end of scope deallocation/_gfortran_caf_deregister is gone for > coarrays (declared in the main program) was a side effect. The > syn

Re: [Patch, Fortran] PR56845 - Fix setting of vptr of CLASS(...),SAVE,ALLOCATABLE

2013-04-10 Thread Tobias Burnus
* PING * Tobias Burnus: An unallocated polymorphic variable has the declared type; however, for static (SAVE) variables, the current code didn't set the value. (That the end of scope deallocation/_gfortran_caf_deregister is gone for coarrays (declared in the main program) was a side effect. T

[Patch, Fortran] PR56845 - Fix setting of vptr of CLASS(...),SAVE,ALLOCATABLE

2013-04-07 Thread Tobias Burnus
An unallocated polymorphic variable has the declared type; however, for static (SAVE) variables, the current code didn't set the value. (That the end of scope deallocation/_gfortran_caf_deregister is gone for coarrays (declared in the main program) was a side effect. The sync/deregistering wil