Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-22 Thread Janus Weil
2018-05-22 20:56 GMT+02:00 H.J. Lu : > On Mon, May 21, 2018 at 10:47 PM, Janus Weil wrote: >> 2018-05-21 18:57 GMT+02:00 Steve Kargl : >>> On Mon, May 21, 2018 at 12:14:13PM +0200, Janus Weil wrote: So, here is the promised follow-up patch. It mostly removes GFC_STD_F2008_TS and rep

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-22 Thread H.J. Lu
On Mon, May 21, 2018 at 10:47 PM, Janus Weil wrote: > 2018-05-21 18:57 GMT+02:00 Steve Kargl : >> On Mon, May 21, 2018 at 12:14:13PM +0200, Janus Weil wrote: >>> >>> So, here is the promised follow-up patch. It mostly removes >>> GFC_STD_F2008_TS and replaces it by GFC_STD_F2018 in a mechanical >>

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
2018-05-21 18:57 GMT+02:00 Steve Kargl : > On Mon, May 21, 2018 at 12:14:13PM +0200, Janus Weil wrote: >> >> So, here is the promised follow-up patch. It mostly removes >> GFC_STD_F2008_TS and replaces it by GFC_STD_F2018 in a mechanical >> manner. Plus, it fixes the resulting fallout in the testsu

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
2018-05-21 22:18 GMT+02:00 Janus Weil : > I'll take care of fixing the remaining libgomp failures. Should be done with r260487. Please let me know if you observe any additional problems. Cheers, Janus

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
2018-05-21 22:16 GMT+02:00 Jakub Jelinek : > On Mon, May 21, 2018 at 01:06:21PM -0700, Steve Kargl wrote: >> On Mon, May 21, 2018 at 09:39:29PM +0200, Janus Weil wrote: >> > >> > Regarding the libgomp.fortran cases: Those are not included in "make >> > check-fortran", right? How do I actually run t

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Jakub Jelinek
On Mon, May 21, 2018 at 01:06:21PM -0700, Steve Kargl wrote: > On Mon, May 21, 2018 at 09:39:29PM +0200, Janus Weil wrote: > > > > Regarding the libgomp.fortran cases: Those are not included in "make > > check-fortran", right? How do I actually run them? Is this documented > > somewhere? > > Good

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread H.J. Lu
On Mon, May 21, 2018 at 1:06 PM, Steve Kargl wrote: > On Mon, May 21, 2018 at 09:39:29PM +0200, Janus Weil wrote: >> >> Regarding the libgomp.fortran cases: Those are not included in "make >> check-fortran", right? How do I actually run them? Is this documented >> somewhere? > > Good question! > >

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Steve Kargl
On Mon, May 21, 2018 at 09:39:29PM +0200, Janus Weil wrote: > > Regarding the libgomp.fortran cases: Those are not included in "make > check-fortran", right? How do I actually run them? Is this documented > somewhere? Good question! When I want to do a specific check, I do something of the form

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
2018-05-21 21:23 GMT+02:00 Steve Kargl : > On Mon, May 21, 2018 at 12:10:01PM -0700, Steve Kargl wrote: >> On Mon, May 21, 2018 at 09:06:40PM +0200, Janus Weil wrote: >> > Hi Steve, >> > >> > > The attached patch fixes a few testcases that were missed >> > > in the original patch. Do you have thes

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Steve Kargl
On Mon, May 21, 2018 at 12:10:01PM -0700, Steve Kargl wrote: > On Mon, May 21, 2018 at 09:06:40PM +0200, Janus Weil wrote: > > Hi Steve, > > > > > The attached patch fixes a few testcases that were missed > > > in the original patch. Do you have these already in an > > > updated patch, or would y

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Steve Kargl
On Mon, May 21, 2018 at 09:06:40PM +0200, Janus Weil wrote: > Hi Steve, > > > The attached patch fixes a few testcases that were missed > > in the original patch. Do you have these already in an > > updated patch, or would you like me to commit my patch? > > I saw the message just now and had no

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
Hi Steve, > The attached patch fixes a few testcases that were missed > in the original patch. Do you have these already in an > updated patch, or would you like me to commit my patch? I saw the message just now and had no time to react yet. Please feel free to commit your patch. Thanks, Janus

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Steve Kargl
On Mon, May 21, 2018 at 09:00:58AM +0200, Janus Weil wrote: > 2018-05-21 0:19 GMT+02:00 Steve Kargl : > > On Sun, May 20, 2018 at 09:44:47PM +0200, Janus Weil wrote: > >> > >> >> The patch still regtests cleanly. Ok for trunk? > >> > > >> > Patch looks good to me. The only thing that worries me is

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Steve Kargl
On Mon, May 21, 2018 at 12:14:13PM +0200, Janus Weil wrote: > > So, here is the promised follow-up patch. It mostly removes > GFC_STD_F2008_TS and replaces it by GFC_STD_F2018 in a mechanical > manner. Plus, it fixes the resulting fallout in the testsuite and > updates the documentation. The non-m

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread H.J. Lu
On Mon, May 21, 2018 at 12:00 AM, Janus Weil wrote: > > Thanks. I have committed this version of the patch as r260433. This caused: FAIL: gfortran.dg/graphite/block-2.f -O (test for excess errors) FAIL: gfortran.dg/graphite/id-19.f -O (test for excess errors) FAIL: gfortran.dg/graphite/id-

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
>> >> Btw, with the arrival of the F2018 standard, I wonder whether it >> >> actually makes sense to keep the option -std=f2008ts, or to remove it >> >> in favor of -std=f2018, since the two Technical Specifications covered >> >> by this flag are now part of F2018 (and pretty much the main part!).

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-21 Thread Janus Weil
2018-05-21 0:19 GMT+02:00 Steve Kargl : > On Sun, May 20, 2018 at 09:44:47PM +0200, Janus Weil wrote: >> >> >> The patch still regtests cleanly. Ok for trunk? >> > >> > Patch looks good to me. The only thing that worries me is >> > whether the patch will cause the SPEC benchmark to throw >> > an e

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-20 Thread Steve Kargl
On Sun, May 20, 2018 at 09:44:47PM +0200, Janus Weil wrote: > > >> The patch still regtests cleanly. Ok for trunk? > > > > Patch looks good to me. The only thing that worries me is > > whether the patch will cause the SPEC benchmark to throw > > an error or warning that it did not before. As I d

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-20 Thread Janus Weil
Hi Steve, thanks for your comments! >> The patch still regtests cleanly. Ok for trunk? > > Patch looks good to me. The only thing that worries me is > whether the patch will cause the SPEC benchmark to throw > an error or warning that it did not before. As I don't have > SPEC benchmark and it c

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-20 Thread Steve Kargl
On Sun, May 20, 2018 at 07:28:49PM +0200, Janus Weil wrote: > > > the attached patch deals with the fact that the Fortran 2018 standard > > marks two features as "deleted" (i.e. no longer supported), namely > > arithmetic IFs and nonblock DO constructs. Both have been obsolescent > > since the 90s

Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-20 Thread Janus Weil
Hi all, > the attached patch deals with the fact that the Fortran 2018 standard > marks two features as "deleted" (i.e. no longer supported), namely > arithmetic IFs and nonblock DO constructs. Both have been obsolescent > since the 90s (and have been warned about by gfortran with appropriate > fl

[Patch, Fortran] PR 85841: [F2018] reject deleted features

2018-05-20 Thread Janus Weil
Hi all, the attached patch deals with the fact that the Fortran 2018 standard marks two features as "deleted" (i.e. no longer supported), namely arithmetic IFs and nonblock DO constructs. Both have been obsolescent since the 90s (and have been warned about by gfortran with appropriate flags). Her