Re: [Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-25 Thread Tobias Burnus
Dear Bob, Bob Deen wrote: Our code does not declare these routines to Fortran, therefore the procedure interface is unknown and this patch "should" not bother anything. Well, it also affects: SUBROUTINE foo() END SUBROUTINE foo and REAL FUNCTION bar() END FUNCTION bar that is proced

Re: [Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-25 Thread Tobias Burnus
Dear Paul, Paul Richard Thomas wrote: Why did Jakub's patch for PR45304 not fix this? He visited the fix in your patch upon build_library_function_decl_1 and gfc_get_intrinsic_lib_fndecl. Well, my patch is in a way a follow up to Jakub's. His patch only fixed the library call definitions and

Re: [Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-22 Thread Bob Deen
Hi Tobias... I've been a lurker here since I posted a problem with varargs (stdarg, really) interfaces back on May 31, 2010 ("Variable argument call does not work on 64-bit gfortran"). You were able to determine that my problem existed on gfortran 4.1 but was fixed in all of 4.2 through 4.6,

Re: [Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-22 Thread Paul Richard Thomas
Dear Tobias, Why did Jakub's patch for PR45304 not fix this? He visited the fix in your patch upon build_library_function_decl_1 and gfc_get_intrinsic_lib_fndecl. Should trans-decl.c(create_function_arglist) have received the same treatment? Otherwise it is OK for trunk. Thanks for the patch.

[Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-22 Thread Tobias Burnus
This patch makes sure that there is no vararg if the procedure interface is known. Before, for functions and subroutines without arguments, no void_list_node. (Related, separate and unfixed issue: For procedures without explicit interface, the interface should be deduced from the usage.) Bui