Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-12 Thread Tobias Burnus
Tobias Burnus wrote: Dominique Dhumieres wrote: I have tried to weaken the test by not using any target and using a regexp of the kind "(int|long)", but I did not succeeded. Ups, I missed that Dominique's and Andreas' 32bit dumps are different ("unsigned int" vs. "character(kind=4)"). Thus,

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-12 Thread Tobias Burnus
Thanks Dominique and Andreas for reporting this issue. Dominique Dhumieres wrote: The test gfortran.dg/finalize_10.f90 fails in 32 bit mode [...] The following patch fixes it [...] I have tried to weaken the test by not using any target and using a regexp of the kind "(int|long)", but I did

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-09 Thread Andreas Schwab
Tobias Burnus writes: > --- /dev/null 2013-06-06 09:52:08.544104880 +0200 > +++ gcc/gcc/testsuite/gfortran.dg/finalize_10.f90 2013-06-03 > 12:32:38.763008261 +0200 > @@ -0,0 +1,39 @@ > +! { dg-do compile } > +! { dg-options "-fdump-tree-original" } > +! > +! PR fortran/37336 > +! > +! Finali

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-09 Thread Dominique Dhumieres
Dear Tobias, The test gfortran.dg/finalize_10.f90 fails in 32 bit mode (see http://gcc.gnu.org/ml/gcc-testresults/2013-06/msg00842.html FAIL: gfortran.dg/finalize_10.f90 -O scan-tree-dump-times original "__builtin_memcpy ((void .) y->_data, (void .) y->_vptr->_def_init, \\

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-08 Thread Tobias Burnus
Hello Mikael, thanks for your patch reviews! Regarding your question: Mikael Morin worte: Le 06/06/2013 10:35, Tobias Burnus a écrit : On May 31, 2013 18:39, Tobias Burnus wrote: This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Additionally, it address

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-08 Thread Mikael Morin
Hello, Le 06/06/2013 10:35, Tobias Burnus a écrit : > * PING * > > Attached is a rediff - including the later posted additional test case > (http://gcc.gnu.org/ml/fortran/2013-05/msg00141.html) > > > On May 31, 2013 18:39, Tobias Burnus wrote: >> This patch adds finalization support for INTENT(

*PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-06 Thread Tobias Burnus
* PING * Attached is a rediff - including the later posted additional test case (http://gcc.gnu.org/ml/fortran/2013-05/msg00141.html) On May 31, 2013 18:39, Tobias Burnus wrote: This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Additionally, it addres

Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-05-31 Thread Tobias Burnus
Tobias Burnus wrote: This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Attached is an additional test case, which checks that the finalization wrapper handles strides correctly. The stride handling occurs trice: - For elemental finalization procedures in

[Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-05-31 Thread Tobias Burnus
This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Additionally, it addresses a missed optimization: The previous code tried to deallocate allocatable components even if the dummy argument was already an allocatable. That's a missed optimization as gfortra