Re: [Patch, Fortran] Add runtime_error function to libgfortran/caf/mpi.c

2011-07-15 Thread Tobias Burnus
Daniel Carrera wrote: On 07/15/2011 10:34 PM, Nathan Froyd wrote: + va_start (ap, message); + fprintf (stderr, message, ap); Did you mean to call vfprintf here? Well spotted! Thanks for the report, Nathan! 2011-07-15 Daniel Carrera * caf/mpi.c (caf_runtime_error): Change fprintf to v

Re: [Patch, Fortran] Add runtime_error function to libgfortran/caf/mpi.c

2011-07-15 Thread Daniel Carrera
On 07/15/2011 10:34 PM, Nathan Froyd wrote: +static void +runtime_error (int error, const char *message, ...) +{ + va_list ap; + fprintf (stderr, "Fortran runtime error on image %d: ", caf_this_image); + va_start (ap, message); + fprintf (stderr, message, ap); Did you mean to call vfprintf here?

Re: [Patch, Fortran] Add runtime_error function to libgfortran/caf/mpi.c

2011-07-15 Thread Nathan Froyd
On 7/9/2011 8:02 AM, Tobias Burnus wrote: Tobias Burnus wrote: This patch adds a run-time error function to mpi.c, which gives a proper error message including the image number. Additionally, it allows to clean up the error handling, avoiding the duplicated declaration of strings. +static void

Re: [Patch, Fortran] Add runtime_error function to libgfortran/caf/mpi.c

2011-07-09 Thread jvdelisle
On Sat, Jul 9, 2011 at 5:02 AM, Tobias Burnus wrote: Tobias Burnus wrote: This patch adds a run-time error function to mpi.c, which gives a proper error message including the image number. Additionally, it allows to clean up the error handling, avoiding the duplicated declaration of strings.

Re: [Patch, Fortran] Add runtime_error function to libgfortran/caf/mpi.c

2011-07-09 Thread Tobias Burnus
Tobias Burnus wrote: This patch adds a run-time error function to mpi.c, which gives a proper error message including the image number. Additionally, it allows to clean up the error handling, avoiding the duplicated declaration of strings. I have not touched the SYNC functions Well, I did n

[Patch, Fortran] Add runtime_error function to libgfortran/caf/mpi.c

2011-07-09 Thread Tobias Burnus
This patch adds a run-time error function to mpi.c, which gives a proper error message including the image number. Additionally, it allows to clean up the error handling, avoiding the duplicated declaration of strings. I have not touched the SYNC functions; they can be handled either after the