Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread Manuel López-Ibáñez
On 23 November 2014 at 10:27, Tobias Burnus wrote: > This patch moves -Wtabs closer to the common diagnostics - and changed the > odd reversed logic of flags = 0 meaning off. You may wish to update the documentation to reflect this change in behavior (invoke.texi, lang.opt and perhaps changes.htm

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread FX
> Because EnabledByLanguage(Fortran,Wall || Wpedantic) isn't supported – using > two separate Wtabs is the work around. > Cf. https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02895.html You’re the best :) FX

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread Tobias Burnus
FX wrote: OK. One question: I don’t understand why you need two separate Wtabs lines in lang.opt. Thanks for the review! Because EnabledByLanguage(Fortran,Wall || Wpedantic) isn't supported – using two separate Wtabs is the work around. Cf. https://gcc.gnu.org/ml/gcc-patches/2014-11/msg0289

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread FX
> Build and regtested on x86-64-gnu-linux. > OK for the trunk? OK. One question: I don’t understand why you need two separate Wtabs lines in lang.opt. FX

[Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread Tobias Burnus
This patch moves -Wtabs closer to the common diagnostics - and changed the odd reversed logic of flags = 0 meaning off. This brings nice common diagnostic features to fixed-form source code for the initial indentation [tab = 6 spaces] (which doesn't show a location), but not to free-form sourc