Re: [PR68432 20/22] Record attributes for define_expand

2015-11-26 Thread Bernd Schmidt
On 11/25/2015 05:08 PM, Richard Sandiford wrote: Also, using a string like that rather than some kind of identifier or a define_icode_attr maybe isn't the best approach? By "some kind of identifier" do you just mean replacing "code,alternative" with a string that doesn't have a comma? Yeah. I

Re: [PR68432 20/22] Record attributes for define_expand

2015-11-25 Thread Richard Sandiford
Bernd Schmidt writes: > On 11/25/2015 01:35 PM, Richard Sandiford wrote: >> The define_subst support made it syntactically possible to add >> attributes to a define_expand, but until now they had been ignored >> by genattrtab.c. This patch allows define_expands to have >> "code,alternative" attri

Re: [PR68432 20/22] Record attributes for define_expand

2015-11-25 Thread Bernd Schmidt
On 11/25/2015 01:35 PM, Richard Sandiford wrote: The define_subst support made it syntactically possible to add attributes to a define_expand, but until now they had been ignored by genattrtab.c. This patch allows define_expands to have "code,alternative" attributes but raises an error for gener

[PR68432 20/22] Record attributes for define_expand

2015-11-25 Thread Richard Sandiford
The define_subst support made it syntactically possible to add attributes to a define_expand, but until now they had been ignored by genattrtab.c. This patch allows define_expands to have "code,alternative" attributes but raises an error for general "insn" attributes. (Insn attributes would crea