Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-27 Thread Thomas Schwinge
the approval by Joseph and Nathan (thanks!), I have now committed this, in r229404: commit 2c4c872529d6e1051fb9cdd641ad5cc9fbc0e2cb Author: tschwinge Date: Tue Oct 27 08:39:15 2015 +0000 [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++ gcc/c-family/

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-11 Thread Nathan Sidwell
On 10/09/15 09:59, Thomas Schwinge wrote: It's s string describing the pragma as parsed thus far. Again, not documenting that as well as our usage of it is totally "standard", see OpenMP's cp_parser_omp_parallel, cp_parser_omp_for, and many more. Ok, I'm not going to hold this to a higher th

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Thomas Schwinge
Hi Nathan! On Fri, 9 Oct 2015 09:34:51 -0400, Nathan Sidwell wrote: > On 10/09/15 09:26, Thomas Schwinge wrote: > > You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel > > functions need documentation? I agree it's a bit terse, but documenting > > these by just listing the accep

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Jakub Jelinek
On Fri, Oct 09, 2015 at 09:34:51AM -0400, Nathan Sidwell wrote: > On 10/09/15 09:26, Thomas Schwinge wrote: > >Hi! > > >You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel > >functions need documentation? I agree it's a bit terse, but documenting > >these by just listing the acce

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Nathan Sidwell
On 10/09/15 09:26, Thomas Schwinge wrote: Hi! You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel functions need documentation? I agree it's a bit terse, but documenting these by just listing the accepted parsing tokens "# pragma acc loop" etc., followed by the *_CLAUSE_MASKs

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Thomas Schwinge
Hi! Thanks to Joseph and you for your review! On Fri, 9 Oct 2015 08:26:37 -0400, Nathan Sidwell wrote: > On 10/08/15 12:39, Thomas Schwinge wrote: > > Some bits extracted out of gomp-4_0-branch, and some other bits > > rewritten; here is a patch to support OpenACC Combined Directives in C, > > C

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Nathan Sidwell
On 10/08/15 12:39, Thomas Schwinge wrote: Hi! Some bits extracted out of gomp-4_0-branch, and some other bits rewritten; here is a patch to support OpenACC Combined Directives in C, C++. (The Fortran front end already does support these.) As far as I know, Jakub is not available at this time,

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-08 Thread Joseph Myers
The C front-end changes are OK, but please follow up with fixes for any issues Jakub identifies. -- Joseph S. Myers jos...@codesourcery.com

[PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-08 Thread Thomas Schwinge
:59:54 2015 +0200 [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++ gcc/c-family/ PR c/64765 PR c/64880 * c-common.h (c_oacc_split_loop_clauses): Declare function. * c-omp.c (c_oacc_split_loop_clauses): New function. gcc/c