Re: [PATCHv4] Vimrc config with GNU formatting

2014-09-19 Thread Segher Boessenkool
On Fri, Sep 19, 2014 at 08:17:28AM +0400, Yury Gribov wrote: > > I was talking about mbr's plugin here :-) > > Ah, ok. Then I'll mention thinca's plugin as a secondary option with a > disclaimer then. Why? There are more plugins that also do the same thing, all more popular (on vim.org at least

Re: [PATCHv4] Vimrc config with GNU formatting

2014-09-18 Thread Yury Gribov
On 09/18/2014 09:20 PM, Segher Boessenkool wrote: > On Thu, Sep 18, 2014 at 12:40:08PM +0400, Yury Gribov wrote: >> When typing 'make .local.vimrc' in GCC build directory one would expect >> .local.vimrc to be created at the root of build directory, not srcdir. > > Yes, you would not expect it to

Re: [PATCHv4] Vimrc config with GNU formatting

2014-09-18 Thread Segher Boessenkool
On Thu, Sep 18, 2014 at 12:40:08PM +0400, Yury Gribov wrote: > When typing 'make .local.vimrc' in GCC build directory one would expect > .local.vimrc to be created at the root of build directory, not srcdir. Yes, you would not expect it to do anything to your source dir, ever :-) > >> +" To enabl

Re: [PATCHv4] Vimrc config with GNU formatting

2014-09-18 Thread Mike Stump
On Sep 18, 2014, at 1:40 AM, Yury Gribov wrote: > How about adding a disclaimer? E.g. "beware that Vim plugins are a GAPING > SECURITY HOLE > so use the at YOUR OWN RISK". (And note that Braun's plugin does use > sandboxes). Building gcc features a security risk at least as big as a plugin for

Re: [PATCHv4] Vimrc config with GNU formatting

2014-09-18 Thread Yury Gribov
On 09/18/2014 07:52 AM, Segher Boessenkool wrote:>> +# Local Vim config >> + >> +vimrc: >> + (cd $(srcdir); $(LN_S) contrib/vimrc .local.vimrc; $(LN_S) contrib/vimrc .lvimrc) >> + > > This is another target than what the doc (in the script itself) mentions. Right, I've forgot to fix it before s

Re: [PATCHv4] Vimrc config with GNU formatting

2014-09-17 Thread Segher Boessenkool
On Wed, Sep 17, 2014 at 09:08:44PM +0400, Yury Gribov wrote: [ Use a proper mime type and target-disposition inline, as contribute.html tells you. Or use a saner email client; since you're using git, try git send-email perhaps? Thanks. ] > index f7c7e38..ee2321f 100644 > --- a/Makefile.tpl > ++

[PATCHv4] Vimrc config with GNU formatting

2014-09-17 Thread Yury Gribov
On 09/16/2014 08:38 PM, Yury Gribov wrote: Hi all, This is the third version of the patch. A list of changes since last version: * move config to contrib so that it's _not_ enabled by default (current score is 2/1 in favor of no Vim config by default) * update Makefile.in to make .local.vimrc if