Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-04-02 Thread Peter Bergner
On 3/28/18 7:21 PM, Segher Boessenkool wrote: > On Wed, Mar 28, 2018 at 07:13:36PM -0500, Peter Bergner wrote: >> Do we care enough to fix these on the release branches? If so, I >> can backport them easily, since they're not that involved. >> I'll leave it up to you to decide. > > If it's easy,

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-28 Thread Segher Boessenkool
On Wed, Mar 28, 2018 at 07:13:36PM -0500, Peter Bergner wrote: > On 3/28/18 4:13 PM, Segher Boessenkool wrote: > > On Wed, Mar 28, 2018 at 01:57:34PM -0500, Peter Bergner wrote: > >> On 3/28/18 12:59 PM, Segher Boessenkool wrote: > >>> It should be something like > >>> > >>> +error ("builtin fu

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-28 Thread Peter Bergner
On 3/28/18 4:13 PM, Segher Boessenkool wrote: > On Wed, Mar 28, 2018 at 01:57:34PM -0500, Peter Bergner wrote: >> On 3/28/18 12:59 PM, Segher Boessenkool wrote: >>> It should be something like >>> >>> +error ("builtin function %qs requires the %qs (or newer), and " >>>"%qs or %qs option

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-28 Thread Segher Boessenkool
On Wed, Mar 28, 2018 at 01:57:34PM -0500, Peter Bergner wrote: > On 3/28/18 12:59 PM, Segher Boessenkool wrote: > > It should be something like > > > > +error ("builtin function %qs requires the %qs (or newer), and " > >"%qs or %qs options", > > + name, "-mcpu=power7", "-m64", "-m

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-28 Thread Peter Bergner
On 3/28/18 12:59 PM, Segher Boessenkool wrote: > It should be something like > > +error ("builtin function %qs requires the %qs (or newer), and " > "%qs or %qs options", > +name, "-mcpu=power7", "-m64", "-mpowerpc64"); > > I don't see other such strings that quote incorrectly

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-28 Thread Segher Boessenkool
On Wed, Mar 28, 2018 at 10:38:49AM -0500, Peter Bergner wrote: > On 3/27/18 5:02 PM, Segher Boessenkool wrote: > >> @@ -15952,6 +15953,10 @@ rs6000_invalid_builtin (enum rs6000_buil > >> name); > >>else if ((fnmask & RS6000_BTM_FLOAT128) != 0) > >> error ("builtin function %qs requir

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-28 Thread Peter Bergner
On 3/27/18 5:02 PM, Segher Boessenkool wrote: >> @@ -15952,6 +15953,10 @@ rs6000_invalid_builtin (enum rs6000_buil >> name); >>else if ((fnmask & RS6000_BTM_FLOAT128) != 0) >> error ("builtin function %qs requires the %qs option", name, >> "-mfloat128"); >> + else if ((fnmask & (

Re: [PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-27 Thread Segher Boessenkool
Hi! On Fri, Mar 23, 2018 at 12:41:38PM -0500, Peter Bergner wrote: > This is the second patch to fix PR84912, which is an ICE when calling some > extended divide builtin functions. This patch is relative to the first > patch. This fixes the ICE by adding a new mask to the builtin functions > tha

[PATCH. rs6000] Fix PR84912: ICE using -m32 on __builtin_divde*, patch #2

2018-03-23 Thread Peter Bergner
This is the second patch to fix PR84912, which is an ICE when calling some extended divide builtin functions. This patch is relative to the first patch. This fixes the ICE by adding a new mask to the builtin functions that are ICEing and then enforcing it is set. I have also added a helpful erro