Re: [PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-08-01 Thread Alfie Richards
The 08/01/2025 14:07, Richard Sandiford wrote: > Alfie Richards writes: > > On 01/08/2025 11:46, Richard Sandiford wrote: > >> Sorry, I think I missed the multiple_targets.cc changes in my > >> previous review. > >> > >> Alfie Richards writes: > >>> + > >>> + tree attrs = remove_attribute ("ta

Re: [PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-08-01 Thread Richard Sandiford
Alfie Richards writes: > On 01/08/2025 11:46, Richard Sandiford wrote: >> Sorry, I think I missed the multiple_targets.cc changes in my >> previous review. >> >> Alfie Richards writes: >>> + >>> + tree attrs = remove_attribute ("target_clones", >>> + DECL_ATTRIBUTES

Re: [PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-08-01 Thread Alfie Richards
On 01/08/2025 11:46, Richard Sandiford wrote: Sorry, I think I missed the multiple_targets.cc changes in my previous review. Alfie Richards writes: diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc index d25277c0a93..44340cbc6a4 100644 --- a/gcc/multiple_target.cc +++ b/gcc/multiple

Re: [PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-08-01 Thread Richard Sandiford
Sorry, I think I missed the multiple_targets.cc changes in my previous review. Alfie Richards writes: > diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc > index d25277c0a93..44340cbc6a4 100644 > --- a/gcc/multiple_target.cc > +++ b/gcc/multiple_target.cc > @@ -313,7 +216,6 @@ create_t

Re: [PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-07-31 Thread Richard Sandiford
FWIW, I agree with Jeff's comment in the v6 series against the duplication of is_valid_asm_symbol and create_new_asm_name. On the aarch64 bits: Alfie Richards writes: > @@ -20549,18 +20540,6 @@ aarch64_mangle_decl_assembler_name (tree decl, tree > id) > This is computed by taking the defaul

[PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-07-28 Thread Alfie Richards
This patch is an overhaul of how FMV name mangling works. Previously mangling logic was duplicated in several places across both target specific and independent code. This patch changes this such that all mangling is done in targetm.mangle_decl_assembler_name (including for the dispatched symbol an

[PATCH v7 02/13] fmv: Refactor FMV name mangling.

2025-07-21 Thread Alfie Richards
This patch is an overhaul of how FMV name mangling works. Previously mangling logic was duplicated in several places across both target specific and independent code. This patch changes this such that all mangling is done in targetm.mangle_decl_assembler_name (including for the dispatched symbol an