Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-07 Thread Luc Grosheintz
On 5/6/25 2:47 PM, Tomasz Kaminski wrote: On Tue, May 6, 2025 at 1:39 PM Luc Grosheintz wrote: On 5/6/25 11:28 AM, Tomasz Kaminski wrote: For better reference, here is illustration of the design I was thinking about: https://godbolt.org/z/7aTcM8fz4 I would also consider having left_mapping

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Tomasz Kaminski
On Tue, May 6, 2025 at 1:39 PM Luc Grosheintz wrote: > > On 5/6/25 11:28 AM, Tomasz Kaminski wrote: > > For better reference, here is illustration of the design I was thinking > > about: > > https://godbolt.org/z/7aTcM8fz4 > > I would also consider having left_mapping_base to accept padding, wher

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Luc Grosheintz
On 5/6/25 1:56 PM, Tomasz Kaminski wrote: On Tue, May 6, 2025 at 1:39 PM Luc Grosheintz wrote: On 5/6/25 11:28 AM, Tomasz Kaminski wrote: For better reference, here is illustration of the design I was thinking about: https://godbolt.org/z/7aTcM8fz4 I would also consider having left_mappin

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Tomasz Kaminski
On Tue, May 6, 2025 at 1:39 PM Luc Grosheintz wrote: > > On 5/6/25 11:28 AM, Tomasz Kaminski wrote: > > For better reference, here is illustration of the design I was thinking > > about: > > https://godbolt.org/z/7aTcM8fz4 > > I would also consider having left_mapping_base to accept padding, wher

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Luc Grosheintz
On 5/6/25 11:28 AM, Tomasz Kaminski wrote: For better reference, here is illustration of the design I was thinking about: https://godbolt.org/z/7aTcM8fz4 I would also consider having left_mapping_base to accept padding, where layout_left uses left_mapping_base. Thank you for all the help! I

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Tomasz Kaminski
For better reference, here is illustration of the design I was thinking about: https://godbolt.org/z/7aTcM8fz4 I would also consider having left_mapping_base to accept padding, where layout_left uses left_mapping_base. On Tue, May 6, 2025 at 10:48 AM Tomasz Kaminski wrote: > The constructors tha

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Tomasz Kaminski
The constructors that are inside mapping_left, that I think represents constructors with other extends: template mapping_left(const mapping_left_base& other) : mapping_left_base(other) {} Can be placed in mapping_left_base, and they will be inherited, as only copy/move constructors are shadowed.

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-06 Thread Tomasz Kaminski
On Mon, May 5, 2025 at 9:20 PM Luc Grosheintz wrote: > > > On 5/5/25 9:44 AM, Tomasz Kaminski wrote: > > On Sat, May 3, 2025 at 2:39 PM Luc Grosheintz > > wrote: > > > >> > >> > >> On 4/30/25 7:13 AM, Tomasz Kaminski wrote: > >>> Hi, > >>> > >>> As we will be landing patches for extends, this wi

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-05 Thread Luc Grosheintz
On 5/5/25 9:44 AM, Tomasz Kaminski wrote: On Sat, May 3, 2025 at 2:39 PM Luc Grosheintz wrote: On 4/30/25 7:13 AM, Tomasz Kaminski wrote: Hi, As we will be landing patches for extends, this will become a separate patch series. I would prefer, if you could commit per layout, and start wi

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-05 Thread Tomasz Kaminski
On Sat, May 3, 2025 at 4:45 PM Luc Grosheintz wrote: > Topic: follow up question about operator() for layout_stride. > > On 4/30/25 7:13 AM, Tomasz Kaminski wrote: > > Hi, > > > > As we will be landing patches for extends, this will become a separate > > patch series. > > I would prefer, if you c

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-05 Thread Tomasz Kaminski
On Sat, May 3, 2025 at 3:42 PM Luc Grosheintz wrote: > This chain discusses changes to `mapping::operator()`. For concrete > discussion, see below. I have a general question: is there a reason > other than style to prefer folds over recursion? > > > On 4/30/25 7:13 AM, Tomasz Kaminski wrote: > >

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-05 Thread Tomasz Kaminski
On Sat, May 3, 2025 at 2:39 PM Luc Grosheintz wrote: > > > On 4/30/25 7:13 AM, Tomasz Kaminski wrote: > > Hi, > > > > As we will be landing patches for extends, this will become a separate > > patch series. > > I would prefer, if you could commit per layout, and start with > layout_right > > (def

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-03 Thread Luc Grosheintz
Topic: follow up question about operator() for layout_stride. On 4/30/25 7:13 AM, Tomasz Kaminski wrote: Hi, As we will be landing patches for extends, this will become a separate patch series. I would prefer, if you could commit per layout, and start with layout_right (default) I try to provid

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-03 Thread Luc Grosheintz
Topics of this chain: - computing __fwd_prod and __rev_prod. - checking representability preconditions. On 4/30/25 7:13 AM, Tomasz Kaminski wrote: Hi, As we will be landing patches for extends, this will become a separate patch series. I would prefer, if you could commit per layout, and start

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-03 Thread Luc Grosheintz
This chain discusses changes to `mapping::operator()`. For concrete discussion, see below. I have a general question: is there a reason other than style to prefer folds over recursion? On 4/30/25 7:13 AM, Tomasz Kaminski wrote: Hi, As we will be landing patches for extends, this will become a

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-03 Thread Luc Grosheintz
On 4/30/25 7:13 AM, Tomasz Kaminski wrote: Hi, As we will be landing patches for extends, this will become a separate patch series. I would prefer, if you could commit per layout, and start with layout_right (default) I try to provide prompt responses, so if that works better for you, you can

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-05-01 Thread Tomasz Kaminski
On Wed, Apr 30, 2025 at 7:13 AM Tomasz Kaminski wrote: > Hi, > > As we will be landing patches for extends, this will become a separate > patch series. > I would prefer, if you could commit per layout, and start with > layout_right (default) > I try to provide prompt responses, so if that works b

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-04-29 Thread Tomasz Kaminski
Hi, As we will be landing patches for extends, this will become a separate patch series. I would prefer, if you could commit per layout, and start with layout_right (default) I try to provide prompt responses, so if that works better for you, you can post a patch only with this layout first, as mo

Re: [PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-04-29 Thread Jonathan Wakely
On Tue, 29 Apr 2025 at 13:56, Luc Grosheintz wrote: > > Implements the parts of layout_left that don't depend on any of the > other layouts. > > libstdc++/ChangeLog: N.B. this needs to be libstdc++-v3/Changelog with "-v3", or the git hooks will reject it. Similarly in patches 6/10 to 10/10. Ther

[PATCH v5 05/10] libstdc++: Implement layout_left from mdspan.

2025-04-29 Thread Luc Grosheintz
Implements the parts of layout_left that don't depend on any of the other layouts. libstdc++/ChangeLog: * include/std/mdspan (layout_left): New class. Signed-off-by: Luc Grosheintz --- libstdc++-v3/include/std/mdspan | 179 1 file changed, 179 insertion