Re: [PATCH v5 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2025-01-14 Thread Tobias Burnus
Hi Sandra, Sandra Loosemore wrote: On 1/9/25 05:17, Tobias Burnus wrote: A case where 'omp error' diagnostic should be delayed - and (here) suppressed: ["should" in the sense it would be good not in the sense "shall".] program_control/sources/error.1.c:15:23: error: ‘pragma omp error’ encou

Re: [PATCH v5 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2025-01-14 Thread Sandra Loosemore
On 1/9/25 05:17, Tobias Burnus wrote: Hi Sandra, I had a first glance at your patch, albeit very superficial. I found one issue reading the code - and observed some issues when running it against some existing external tests. I will have a deeper looker later, will now first do another iteratio

Re: [PATCH v5 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2025-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 01:17:24PM +0100, Tobias Burnus wrote: > A case where 'omp error' diagnostic should be delayed - and (here) suppressed: > > program_control/sources/error.1.c:15:23: error: ‘pragma omp error’ > encountered: GNU compiler required. >15 | otherwise(error at(com

Re: [PATCH v5 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2025-01-09 Thread Tobias Burnus
Hi Sandra, I had a first glance at your patch, albeit very superficial. I found one issue reading the code - and observed some issues when running it against some existing external tests. I will have a deeper looker later, will now first do another iteration on your main/middle-end patch #2, whi

[PATCH v5 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2024-12-09 Thread Sandra Loosemore
Additional shared C/C++ testcases are included in a subsequent patch in this series. gcc/c-family/ChangeLog PR middle-end/112779 PR middle-end/113904 * c-common.h (enum c_omp_directive_kind): Add C_OMP_DIR_META. (c_omp_expand_variant_construct): Declare. * c