Re: [PATCH v3 2/2] Prevent divide-by-zero

On Wed, Aug 28, 2024 at 9:21 AM Richard Biener wrote: > > On Wed, Aug 28, 2024 at 12:43 AM Edwin Lu wrote: > > > > On 8/22/2024 5:35 AM, Richard Biener wrote: > > > On Thu, Aug 22, 2024 at 1:03 AM Edwin Lu wrote: > > >> > > >> Hi, > > >> > > >> Just wanted to ping this for more guidance. > > > >

Re: [PATCH v3 2/2] Prevent divide-by-zero

On Wed, Aug 28, 2024 at 12:43 AM Edwin Lu wrote: > > On 8/22/2024 5:35 AM, Richard Biener wrote: > > On Thu, Aug 22, 2024 at 1:03 AM Edwin Lu wrote: > >> > >> Hi, > >> > >> Just wanted to ping this for more guidance. > > > > It's difficult for me as long as I cannot investigate this with a testca

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 8/22/2024 5:35 AM, Richard Biener wrote: On Thu, Aug 22, 2024 at 1:03 AM Edwin Lu wrote: Hi, Just wanted to ping this for more guidance. It's difficult for me as long as I cannot investigate this with a testcase. Can we go ahead with the other parts so the testcase can be added and the

Re: [PATCH v3 2/2] Prevent divide-by-zero

On Thu, Aug 22, 2024 at 1:03 AM Edwin Lu wrote: > > Hi, > > Just wanted to ping this for more guidance. It's difficult for me as long as I cannot investigate this with a testcase. Can we go ahead with the other parts so the testcase can be added and the issue reproduced? Richard. > Edwin > > O

Re: [PATCH v3 2/2] Prevent divide-by-zero

Hi, Just wanted to ping this for more guidance. Edwin On 7/24/2024 12:03 PM, Edwin Lu wrote: On 7/24/2024 3:52 AM, Richard Biener wrote: On Wed, Jul 24, 2024 at 1:31 AM Edwin Lu wrote: On 7/23/2024 11:20 AM, Richard Sandiford wrote: Edwin Lu writes: On 7/23/2024 4:56 AM, Richard Biener

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 7/26/24 06:30, Richard Biener wrote: On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill wrote: From: Greg McGary gcc/ChangeLog: * gcc/tree-vect-stmts.cc (gcc/tree-vect-stmts.cc): Prevent divide-by-zero. * testsuite/gcc.target/riscv/rvv/autovec/no-segment.c: Remove dg-ice. -

Re: [PATCH v3 2/2] Prevent divide-by-zero

On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill wrote: > > From: Greg McGary > > gcc/ChangeLog: > * gcc/tree-vect-stmts.cc (gcc/tree-vect-stmts.cc): Prevent > divide-by-zero. > * testsuite/gcc.target/riscv/rvv/autovec/no-segment.c: Remove dg-ice. > --- > No changes in v3. Depends

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 7/24/2024 3:03 AM, Robin Dapp wrote: Thanks for the explanation! I have a few clarification questions about this. If I understand correctly, B would represent the number of elements the vector can have (for 128b vector operating on 32b elements, B == 4, but if operating on 64b elements B ==

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 7/24/2024 3:03 AM, Robin Dapp wrote: Thanks for the explanation! I have a few clarification questions about this. If I understand correctly, B would represent the number of elements the vector can have (for 128b vector operating on 32b elements, B == 4, but if operating on 64b elements B ==

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 7/24/2024 3:52 AM, Richard Biener wrote: On Wed, Jul 24, 2024 at 1:31 AM Edwin Lu wrote: On 7/23/2024 11:20 AM, Richard Sandiford wrote: Edwin Lu writes: On 7/23/2024 4:56 AM, Richard Biener wrote: On Tue, Jul 23, 2024 at 1:03 AM Edwin Lu wrote: Hi Richard, On 5/31/2024 1:48 AM, Ri

Re: [PATCH v3 2/2] Prevent divide-by-zero

On Wed, Jul 24, 2024 at 1:31 AM Edwin Lu wrote: > > > On 7/23/2024 11:20 AM, Richard Sandiford wrote: > > Edwin Lu writes: > >> On 7/23/2024 4:56 AM, Richard Biener wrote: > >>> On Tue, Jul 23, 2024 at 1:03 AM Edwin Lu wrote: > Hi Richard, > > On 5/31/2024 1:48 AM, Richard Biener

Re: [PATCH v3 2/2] Prevent divide-by-zero

> Thanks for the explanation! I have a few clarification questions about this. > If I understand correctly, B would represent the number of elements the > vector can have (for 128b vector operating on 32b elements, B == 4, but if > operating on 64b elements B == 2); however, I'm not too sure what A

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 7/23/2024 11:20 AM, Richard Sandiford wrote: Edwin Lu writes: On 7/23/2024 4:56 AM, Richard Biener wrote: On Tue, Jul 23, 2024 at 1:03 AM Edwin Lu wrote: Hi Richard, On 5/31/2024 1:48 AM, Richard Biener wrote: On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill wrote: From: Greg McGary

Re: [PATCH v3 2/2] Prevent divide-by-zero

Edwin Lu writes: > On 7/23/2024 4:56 AM, Richard Biener wrote: >> On Tue, Jul 23, 2024 at 1:03 AM Edwin Lu wrote: >>> Hi Richard, >>> >>> On 5/31/2024 1:48 AM, Richard Biener wrote: On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill wrote: > From: Greg McGary Still a NACK. If

Re: [PATCH v3 2/2] Prevent divide-by-zero

On 7/23/2024 4:56 AM, Richard Biener wrote: On Tue, Jul 23, 2024 at 1:03 AM Edwin Lu wrote: Hi Richard, On 5/31/2024 1:48 AM, Richard Biener wrote: On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill wrote: From: Greg McGary Still a NACK. If remain ends up zero then

Re: [PATCH v3 2/2] Prevent divide-by-zero

On Tue, Jul 23, 2024 at 1:03 AM Edwin Lu wrote: > > Hi Richard, > > On 5/31/2024 1:48 AM, Richard Biener wrote: > > On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill > > wrote: > >> > >> From: Greg McGary > > > > Still a NACK. If remain ends up zero then > > > > /* Try to us

Re: [PATCH v3 2/2] Prevent divide-by-zero

On Thu, May 30, 2024 at 2:11 AM Patrick O'Neill wrote: > > From: Greg McGary Still a NACK. If remain ends up zero then /* Try to use a single smaller load when we are about to load excess elements compared to the unrolled scalar

[PATCH v3 2/2] Prevent divide-by-zero

From: Greg McGary gcc/ChangeLog: * gcc/tree-vect-stmts.cc (gcc/tree-vect-stmts.cc): Prevent divide-by-zero. * testsuite/gcc.target/riscv/rvv/autovec/no-segment.c: Remove dg-ice. --- No changes in v3. Depends on the risc-v backend option added in patch 1 to trigger the ICE. --- g