Re: [PATCH v3 05/18] convert the C front end to automatic dependencies

2013-09-18 Thread Mike Stump
On Sep 18, 2013, at 8:36 AM, Tom Tromey wrote: > It occurred to me this morning that AC_PROG_CC_C_O only checks the C > compiler, but we're generally using the C++ compiler for gcc now. So I > think this was already all obsolete. The reality is that checking the C compiler is likely enough on al

Re: [PATCH v3 05/18] convert the C front end to automatic dependencies

2013-09-18 Thread Tom Tromey
Paolo> As I wrote in another reply, I suspect this breaks bootstrap with Paolo> compilers that do not support "-c -o", if it is not broken yet. It occurred to me this morning that AC_PROG_CC_C_O only checks the C compiler, but we're generally using the C++ compiler for gcc now. So I think this wa

Re: [PATCH v3 05/18] convert the C front end to automatic dependencies

2013-09-18 Thread Paolo Bonzini
Il 16/09/2013 22:58, Tom Tromey ha scritto: > Paolo> The series looks okay to me with that change. > > Two last questions while I'm testing my rebase -- > > First, do you mind if I resend the whole series? Otherwise I can try to > pick out just the patches that have changed, plus the additional

Re: [PATCH v3 05/18] convert the C front end to automatic dependencies

2013-09-16 Thread Tom Tromey
Paolo> The series looks okay to me with that change. Two last questions while I'm testing my rebase -- First, do you mind if I resend the whole series? Otherwise I can try to pick out just the patches that have changed, plus the additional patches. Second, should I get a separate ok for the cha

Re: [PATCH v3 05/18] convert the C front end to automatic dependencies

2013-09-16 Thread Paolo Bonzini
Il 20/08/2013 15:59, Tom Tromey ha scritto: > This converts the C front end. > > Note that this fixes a latent bug in gcc/Makefile.in's definition of > C_TREE_H. This is needed to avoid breaking this build with this > patch. > > * Makefile.in (C_TREE_H): Reference c/c-tree.h. > > *

Re: [PATCH v3 05/18] convert the C front end to automatic dependencies

2013-09-16 Thread Tom Tromey
> "Paolo" == Paolo Bonzini writes: Paolo> Can you put before patch 4 another that defines OUTPUT_OPTION to "-o $@" Paolo> unconditionally and removes all traces of NO_MINUS_C_MINUS_O? Sure thing. Paolo> The series looks okay to me with that change. Thanks very much for your reviews. I'll s

[PATCH v3 05/18] convert the C front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts the C front end. Note that this fixes a latent bug in gcc/Makefile.in's definition of C_TREE_H. This is needed to avoid breaking this build with this patch. * Makefile.in (C_TREE_H): Reference c/c-tree.h. * Make-lang.in (c/gccspec.o): Remove. (CFLAGS-c/gccs