Re: [PATCH v3] c++, coroutines: Fix awaiter var creation [PR116506].

2025-02-03 Thread Jason Merrill
On 12/9/24 7:53 PM, Jason Merrill wrote: On 12/9/24 1:52 PM, Iain Sandoe wrote: On 9 Dec 2024, at 17:41, Jason Merrill wrote: On 10/31/24 4:40 AM, Iain Sandoe wrote: This version tested on x86_64-darwin,linux, powerpc64-linux, on folly and by Sam on wider codebases, Why don't you need a va

Re: [PATCH v3] c++, coroutines: Fix awaiter var creation [PR116506].

2024-12-09 Thread Jason Merrill
On 12/9/24 1:52 PM, Iain Sandoe wrote: On 9 Dec 2024, at 17:41, Jason Merrill wrote: On 10/31/24 4:40 AM, Iain Sandoe wrote: This version tested on x86_64-darwin,linux, powerpc64-linux, on folly and by Sam on wider codebases, Why don't you need a variable to preserve o across suspensions i

Re: [PATCH v3] c++, coroutines: Fix awaiter var creation [PR116506].

2024-12-09 Thread Iain Sandoe
> On 9 Dec 2024, at 17:41, Jason Merrill wrote: > > On 10/31/24 4:40 AM, Iain Sandoe wrote: >> This version tested on x86_64-darwin,linux, powerpc64-linux, on folly >> and by Sam on wider codebases, > Why don't you need a variable to preserve o across suspensions if it's a > call retu

Re: [PATCH v3] c++, coroutines: Fix awaiter var creation [PR116506].

2024-12-09 Thread Jason Merrill
On 10/31/24 4:40 AM, Iain Sandoe wrote: This version tested on x86_64-darwin,linux, powerpc64-linux, on folly and by Sam on wider codebases, Why don't you need a variable to preserve o across suspensions if it's a call returning lvalue reference? We always need a space for the awaiter, unless

Re: [PATCH v3] c++, coroutines: Fix awaiter var creation [PR116506].

2024-11-29 Thread Iain Sandoe
Hi Jason, gentle ping for this one (sorry I forgot to ping earlier and then WG21 …) > On 31 Oct 2024, at 08:40, Iain Sandoe wrote: > > This version tested on x86_64-darwin,linux, powerpc64-linux, on folly > and by Sam on wider codebases, > Why don't you need a variable to preserve o acro

[PATCH v3] c++, coroutines: Fix awaiter var creation [PR116506].

2024-10-31 Thread Iain Sandoe
This version tested on x86_64-darwin,linux, powerpc64-linux, on folly and by Sam on wider codebases, >>>Why don't you need a variable to preserve o across suspensions if it's a >>>call returning lvalue reference? >>We always need a space for the awaiter, unless it is already a >>variable/paramet